Re: [PATCH v11 1/2] gdb: add annotation in 'info locals' command for variables shadowing case

[Eli Zaretskii <eliz@gnu.org>]

> From: "Ijaz, Abdul B" <abdul.b.ijaz@intel.com>
> CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
> 	"pedro@palves.net" <pedro@palves.net>, "philippe.waroquiers@skynet.be"
> 	<philippe.waroquiers@skynet.be>, "aburgess@redhat.com" <aburgess@redhat.com>,
> 	"Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>, "Schimpe,
>  Christina" <christina.schimpe@intel.com>, "lsix@lancelotsix.com"
> 	<lsix@lancelotsix.com>, "tom@tromey.com" <tom@tromey.com>
> Date: Fri, 28 Nov 2025 14:37:34 +0000
> 
> Hi Eli,
> 
> Thanks a lot for the feedback. Please review my feedback below.
> 
> >> +  the output of this command for variables shadowing case.
> 
> Eli>This sounds like the annotations are only shown when variables' values are shadowed.  Is that really the case?  If so, why not show also annotations for the non-shadowed variables?
> 
> Abdul>Yes it the case. As otherwise this information is not useful. For example if variable is shown for "info locals" 5 times then 4 instances will have shadowed annotation with location info while the one instance will be without it. So it will be easier for user to identify the variable in current scope from the rest but any variable is only shown once then the information is not that useful.

I think it will be better if we would show the last line before the
location of PC where each local got its value.

I will not argue about this anymore, but I'd like to hear what others
think about that.