From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2fg0J+y+KWkD2T4AWB0awg (envelope-from ) for ; Fri, 28 Nov 2025 10:25:32 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=LEIUp5er; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9A2A71E0B6; Fri, 28 Nov 2025 10:25:32 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 99D691E08D for ; Fri, 28 Nov 2025 10:25:31 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 08DD43858D29 for ; Fri, 28 Nov 2025 15:25:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 08DD43858D29 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=LEIUp5er Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 4F5733858D20 for ; Fri, 28 Nov 2025 15:23:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4F5733858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4F5733858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764343427; cv=none; b=mhqokQ4FxyX8cI5K/brGmQAcUkGxqq5DK3Y7RUQWjcwI5u0n7bsDUsi94K5Crgtx5pg+Be8iNMvTEVc6eSyCvPaDF/eAUCYYqwodWZmOGkalUAntJ26GmxiENQCyJ6MI1LoCBSsqw94CR49VFOJcJ3gZlQxaVuF86tPl3vo/EAY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764343427; c=relaxed/simple; bh=3K1FLoBl7xeld5T1vFQ4yHziSXerCa8oNsU8IaiS0WE=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=C/xiE5VHwccEzaFEfBVKd2R7hnU6T4AtX/wuIkb2CZvrD2UHfCEBP82o7M0psteqQICgQVMGGcnJN60wZ3nb0vpuHQ+bDhZrdufPZN8lWouUGBhcfjwvYDzVSvKttxwOwCVVAG280ZeTr2V7/OgQAZO/130jGmiB6zcsI1iNeAA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4F5733858D20 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vP0Jz-0001cP-PQ; Fri, 28 Nov 2025 10:23:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GrIgIvtWwnfXoX+23kin6a64iUGJa4lMexUNjp0aa3o=; b=LEIUp5erDq9F fum3J69Q9+Rc85685PiVXSMMJY49qjsql/v0ekvUSEK6neGOhCOYt/ADHd5O9crk7xWTyugM+MJUd cPWB7zMyrCM+h406PmoR+jF6c+cLp1+4sIp9pNhYjSlLJxaBWfPzma4YriCj1YheS+BXI+3ImkrYC 9MWGdrJFyWt5ldfx8Pr+P3lqA0Z8gzoEoDeaRjqBYz4QexerCRITqFc5BjSuxBl0KO9+vjHeyDk2d Om3EgXXzXb5P/gH3OBnlMiBQmNVc/DK6LKQh/VcX1475sVbSsAkbAsWvg72JXCzw6wdrrgW7G8CWX wVQ3RJGsZsK7ZtimDfmcTg==; Date: Fri, 28 Nov 2025 17:23:39 +0200 Message-Id: <86qzti89l0.fsf@gnu.org> From: Eli Zaretskii To: "Ijaz, Abdul B" Cc: gdb-patches@sourceware.org, pedro@palves.net, philippe.waroquiers@skynet.be, aburgess@redhat.com, tankut.baris.aktemur@intel.com, christina.schimpe@intel.com, lsix@lancelotsix.com, tom@tromey.com In-Reply-To: (abdul.b.ijaz@intel.com) Subject: Re: [PATCH v11 1/2] gdb: add annotation in 'info locals' command for variables shadowing case References: <20251128120317.12208-1-abdul.b.ijaz@intel.com> <20251128120317.12208-2-abdul.b.ijaz@intel.com> <86zf868cq7.fsf@gnu.org> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: "Ijaz, Abdul B" > CC: "gdb-patches@sourceware.org" , > "pedro@palves.net" , "philippe.waroquiers@skynet.be" > , "aburgess@redhat.com" , > "Aktemur, Tankut Baris" , "Schimpe, > Christina" , "lsix@lancelotsix.com" > , "tom@tromey.com" > Date: Fri, 28 Nov 2025 14:37:34 +0000 > > Hi Eli, > > Thanks a lot for the feedback. Please review my feedback below. > > >> + the output of this command for variables shadowing case. > > Eli>This sounds like the annotations are only shown when variables' values are shadowed. Is that really the case? If so, why not show also annotations for the non-shadowed variables? > > Abdul>Yes it the case. As otherwise this information is not useful. For example if variable is shown for "info locals" 5 times then 4 instances will have shadowed annotation with location info while the one instance will be without it. So it will be easier for user to identify the variable in current scope from the rest but any variable is only shown once then the information is not that useful. I think it will be better if we would show the last line before the location of PC where each local got its value. I will not argue about this anymore, but I'd like to hear what others think about that.