From: Eli Zaretskii <eliz@gnu.org>
To: sunilkumar.dora@windriver.com
Cc: gdb-patches@sourceware.org, kevinb@redhat.com, macro@orcam.me.uk,
Randy.MacLeod@windriver.com, Sundeep.Kokkonda@windriver.com,
schwab@linux-m68k.org, tromey@sourceware.org, simark@simark.ca
Subject: Re: [PATCH v5 2/2] gdb/ser-unix: add POSIX cfsetispeed/cfsetospeed support for custom baud rates
Date: Tue, 24 Mar 2026 19:15:05 +0200 [thread overview]
Message-ID: <86qzp9xi7a.fsf@gnu.org> (raw)
In-Reply-To: <20260324164527.1446549-3-sunilkumar.dora@windriver.com>
> From: sunilkumar.dora@windriver.com
> Cc: SunilKumar.Dora@windriver.com, kevinb@redhat.com, macro@orcam.me.uk,
> eliz@gnu.org, Randy.MacLeod@windriver.com,
> Sundeep.Kokkonda@windriver.com, schwab@linux-m68k.org,
> tromey@sourceware.org, simark@simark.ca
> Date: Tue, 24 Mar 2026 09:45:27 -0700
>
> From: Sunil Dora <sunilkumar.dora@windriver.com>
>
> glibc 2.42 and later, and GNU Hurd, accept arbitrary baud rates
> directly via cfsetispeed and cfsetospeed. This behaviour is expected
> to be standardized in a future POSIX revision.
>
> Introduce a configure-time test (HAVE_CFSETSPEED_ARBITRARY) that
> detects this capability and add a new platform-agnostic helper
> set_custom_baudrate_posix. The main dispatcher now prefers the POSIX
> path when it is available, falling back to the existing Linux (BOTHER)
> or Darwin (IOSSIOSPEED) implementations otherwise.
>
> The HAVE_CUSTOM_BAUDRATE_SUPPORT guard is extended to also cover the
> new POSIX case.
>
> Suggested-by: Kevin Buettner <kevinb@redhat.com>
> Suggested-by: Maciej W. Rozycki <macro@orcam.me.uk>
> Signed-off-by: Sunil Dora <sunilkumar.dora@windriver.com>
> ---
> gdb/NEWS | 6 ++++++
> gdb/config.in | 3 +++
> gdb/configure | 39 ++++++++++++++++++++++++++++++++++++++
> gdb/configure.ac | 19 +++++++++++++++++++
> gdb/ser-unix.c | 49 +++++++++++++++++++++++++++++++++++++++---------
> 5 files changed, 107 insertions(+), 9 deletions(-)
Thanks, the NEWS part is okay.
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
next prev parent reply other threads:[~2026-03-24 17:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 16:45 [PATCH v5 0/2] PR gdb/33747: gdb/ser-unix: fix musl build failure and add POSIX custom baud rate support sunilkumar.dora
2026-03-24 16:45 ` [PATCH v5 1/2] gdb/ser-unix: fix musl build failure when setting custom baud rates sunilkumar.dora
2026-03-24 16:45 ` [PATCH v5 2/2] gdb/ser-unix: add POSIX cfsetispeed/cfsetospeed support for " sunilkumar.dora
2026-03-24 17:15 ` Eli Zaretskii [this message]
2026-03-27 18:15 ` [PATCH v5 0/2] PR gdb/33747: gdb/ser-unix: fix musl build failure and add POSIX custom baud rate support Kevin Buettner
2026-03-27 19:26 ` Sunil Kumar Dora
2026-04-14 16:28 ` Sunil Kumar Dora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86qzp9xi7a.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=Randy.MacLeod@windriver.com \
--cc=Sundeep.Kokkonda@windriver.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=macro@orcam.me.uk \
--cc=schwab@linux-m68k.org \
--cc=simark@simark.ca \
--cc=sunilkumar.dora@windriver.com \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox