Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: sunilkumar.dora@windriver.com
To: gdb-patches@sourceware.org
Cc: SunilKumar.Dora@windriver.com, kevinb@redhat.com,
	macro@orcam.me.uk, eliz@gnu.org, Randy.MacLeod@windriver.com,
	Sundeep.Kokkonda@windriver.com, schwab@linux-m68k.org,
	tromey@sourceware.org, simark@simark.ca
Subject: [PATCH v5 0/2] PR gdb/33747: gdb/ser-unix: fix musl build failure and add POSIX custom baud rate support
Date: Tue, 24 Mar 2026 09:45:25 -0700	[thread overview]
Message-ID: <20260324164527.1446549-1-sunilkumar.dora@windriver.com> (raw)

From: Sunil Dora <sunilkumar.dora@windriver.com>

On musl-based systems <asm/termbits.h> exposes BOTHER, so the
Linux-specific custom baud rate path was being compiled.  However,
musl's struct termios does not provide the public members c_ispeed
and c_ospeed, causing a build failure.

This series fixes the build issue at the macro level (patch 1).
It then adds the preferred POSIX cfsetispeed/cfsetospeed path as the
first choice on platforms where the host libc supports arbitrary baud
rates, such as glibc 2.42 and later, GNU Hurd, and potentially other
libc implementations (patch 2).  The existing Linux (termios2/BOTHER)
and Darwin (IOSSIOSPEED) paths remain as fallbacks.

The two patches are independent:
  - Patch 1 is a pure build fix with no functional change.
  - Patch 2 adds the new POSIX feature on top of the fixed guard.

set_custom_baudrate_linux is left unchanged.

Changes since V4:
  - Split into two patches, with patch 1 as a pure build fix
    and patch 2 adding the POSIX interface.
  - Fixed #if guard formatting and added full stop to the
    AC_DEFINE description.
  - Removed parentheses from function name references in
    commit messages and comments.
  - Updated NEWS entry to describe which configurations are
    affected.

v4: https://sourceware.org/pipermail/gdb-patches/2026-March/226133.html
v3: https://sourceware.org/pipermail/gdb-patches/2026-March/225952.html
v2: https://sourceware.org/pipermail/gdb-patches/2026-February/225251.html
v1: https://sourceware.org/pipermail/gdb-patches/2026-February/224968.html

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33747

Sunil Dora (2):
  gdb/ser-unix: fix musl build failure when setting custom baud rates
  gdb/ser-unix: add POSIX cfsetispeed/cfsetospeed support for custom
    baud rates

 gdb/NEWS         |  6 ++++++
 gdb/config.in    |  6 ++++++
 gdb/configure    | 52 ++++++++++++++++++++++++++++++++++++++++++++++++
 gdb/configure.ac | 22 ++++++++++++++++++++
 gdb/ser-unix.c   | 47 ++++++++++++++++++++++++++++++++++++-------
 5 files changed, 126 insertions(+), 7 deletions(-)

-- 
2.49.0


             reply	other threads:[~2026-03-24 16:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-24 16:45 sunilkumar.dora [this message]
2026-03-24 16:45 ` [PATCH v5 1/2] gdb/ser-unix: fix musl build failure when setting custom baud rates sunilkumar.dora
2026-03-24 16:45 ` [PATCH v5 2/2] gdb/ser-unix: add POSIX cfsetispeed/cfsetospeed support for " sunilkumar.dora
2026-03-24 17:15   ` Eli Zaretskii
2026-03-27 18:15 ` [PATCH v5 0/2] PR gdb/33747: gdb/ser-unix: fix musl build failure and add POSIX custom baud rate support Kevin Buettner
2026-03-27 19:26   ` Sunil Kumar Dora
2026-04-14 16:28   ` Sunil Kumar Dora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260324164527.1446549-1-sunilkumar.dora@windriver.com \
    --to=sunilkumar.dora@windriver.com \
    --cc=Randy.MacLeod@windriver.com \
    --cc=Sundeep.Kokkonda@windriver.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    --cc=macro@orcam.me.uk \
    --cc=schwab@linux-m68k.org \
    --cc=simark@simark.ca \
    --cc=tromey@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox