Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 5/5] Adjust gdb.python/py-events.exp for Cygwin/MinGW
Date: Fri, 22 May 2026 10:18:35 +0300	[thread overview]
Message-ID: <86qzn3yks4.fsf@gnu.org> (raw)
In-Reply-To: <20260522001626.393908-6-pedro@palves.net> (message from Pedro Alves on Fri, 22 May 2026 01:16:26 +0100)

> From: Pedro Alves <pedro@palves.net>
> Date: Fri, 22 May 2026 01:16:26 +0100
> 
> This commit fixes several issues in gdb.python/py-events.exp for
> Cygwin and MinGW.  With these fixed, the testcase passes cleanly on
> Cygwin.  I haven't tested on MinGW, but at least the test should be
> able to compile & run there now.
> 
> 1) - GDB prints Windows thread IDs in hex:
> 
>  (gdb) thread
>  [Current thread is 1 (Thread 9528.0xa9c)]
> 
> The corrent code assume decimal, so we only (incorrectly) extract the
> "0" after the dot.
> 
> 2) - Thread and process ID number spaces are different.
> 
> The current code assumes that the extract thread is is the same number
                                                   ^^
Typo: should be "ID".

> as the extracted process id, which is not true on Windows.
> 
> 3) - there is no "info proc" command on Windows
> 
> The testcase is using "info proc" to extract the inferior's process
> it.  But "info proc" does not exist on all targets, including Windows.
  ^^
Same here.

Thanks.

(I don't add the reviewed-by signature, because I cannot review the
expect code.)

      reply	other threads:[~2026-05-22  7:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-22  0:16 [PATCH 0/5] Fix a few Cygwin/MinGW problems Pedro Alves
2026-05-22  0:16 ` [PATCH 1/5] Fix "set cwd ..." on Cygwin, part 1 Pedro Alves
2026-05-22 13:54   ` Tom Tromey
2026-05-22  0:16 ` [PATCH 2/5] Fix "set cwd ..." on Cygwin, part 2 Pedro Alves
2026-05-22 14:37   ` Tom Tromey
2026-05-25 16:43     ` Pedro Alves
2026-05-22  0:16 ` [PATCH 3/5] Adjust gdb.base/exitsignal.exp for Cygwin Pedro Alves
2026-05-22 15:09   ` Tom Tromey
2026-05-22  0:16 ` [PATCH 4/5] Fix exit/signal code on Cygwin Pedro Alves
2026-05-22  7:15   ` Eli Zaretskii
2026-05-25 16:47     ` Pedro Alves
2026-05-22  0:16 ` [PATCH 5/5] Adjust gdb.python/py-events.exp for Cygwin/MinGW Pedro Alves
2026-05-22  7:18   ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86qzn3yks4.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@palves.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox