From: Pedro Alves <pedro@palves.net>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/5] Fix "set cwd ..." on Cygwin, part 2
Date: Mon, 25 May 2026 17:43:57 +0100 [thread overview]
Message-ID: <6b195fee-8de4-4e62-98fc-b0b1b23b40a2@palves.net> (raw)
In-Reply-To: <87ecj38q87.fsf@tromey.com>
On 2026-05-22 15:37, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:
>
> Pedro> On the gdbserver side, we're just completely missing the
> Pedro> cygwin_conv_path logic. This commit adds it. The code isn't shared
> Pedro> with GDB because GDB uses wide chars, and gdbserver uses narrow char.
>
> I wonder why, and whether this results in any differences in behavior.
>
For the "why", I think it's just historical.
See:
https://inbox.sourceware.org/gdb-patches/20100228150844.GH5683@calimero.vinschen.de/
... for when GDB started using the Wide versions, which talks about the Ansi limitations.
And then, nobody ever adjusted GDBserver.
> Anyway this looks good.
> Approved-By: Tom Tromey <tom@tromey.com>
Thanks, I merged patches 1, 2, and 3. I'll be sending a v2 with a new version of the remainder, in a sec.
Pedro Alves
next prev parent reply other threads:[~2026-05-25 16:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 0:16 [PATCH 0/5] Fix a few Cygwin/MinGW problems Pedro Alves
2026-05-22 0:16 ` [PATCH 1/5] Fix "set cwd ..." on Cygwin, part 1 Pedro Alves
2026-05-22 13:54 ` Tom Tromey
2026-05-22 0:16 ` [PATCH 2/5] Fix "set cwd ..." on Cygwin, part 2 Pedro Alves
2026-05-22 14:37 ` Tom Tromey
2026-05-25 16:43 ` Pedro Alves [this message]
2026-05-22 0:16 ` [PATCH 3/5] Adjust gdb.base/exitsignal.exp for Cygwin Pedro Alves
2026-05-22 15:09 ` Tom Tromey
2026-05-22 0:16 ` [PATCH 4/5] Fix exit/signal code on Cygwin Pedro Alves
2026-05-22 7:15 ` Eli Zaretskii
2026-05-25 16:47 ` Pedro Alves
2026-05-22 0:16 ` [PATCH 5/5] Adjust gdb.python/py-events.exp for Cygwin/MinGW Pedro Alves
2026-05-22 7:18 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b195fee-8de4-4e62-98fc-b0b1b23b40a2@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox