From: Yao Qi <qiyaoltc@gmail.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: Simon Marchi <simon.marchi@polymtl.ca>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Make arm_record_test work on big-endian machines
Date: Mon, 12 Mar 2018 17:09:00 -0000 [thread overview]
Message-ID: <86po49dxw3.fsf@gmail.com> (raw)
In-Reply-To: <fb6d077c-d731-03b9-c9cd-b03a8f1ab161@ericsson.com> (Simon Marchi's message of "Mon, 12 Mar 2018 11:41:34 -0400")
Simon Marchi <simon.marchi@ericsson.com> writes:
> What do you think about the patch below? Functionally, it should be identical
> to what you suggested, but I think it's clear to fix extract_arm_insn instead.
>
Patch looks good to me. Thanks.
> +
> + insn_record->arm_insn
> + = (uint32_t) extract_unsigned_integer (&buf[0], 2, endian);
> +
> + if (insn_size == 4)
> + {
> + insn_record->arm_insn <<= 16;
> + insn_record->arm_insn
> + |= (uint32_t) extract_unsigned_integer (&buf[2], 2, endian);
Better to add some comments here.
--
Yao (齐尧)
next prev parent reply other threads:[~2018-03-12 17:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 3:09 Simon Marchi
2018-03-12 14:16 ` Yao Qi
2018-03-12 15:42 ` Simon Marchi
2018-03-12 17:09 ` Yao Qi [this message]
2018-03-12 18:54 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86po49dxw3.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox