From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12776 invoked by alias); 12 Mar 2018 17:09:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12656 invoked by uid 89); 12 Mar 2018 17:09:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:static. X-HELO: mail-wr0-f173.google.com Received: from mail-wr0-f173.google.com (HELO mail-wr0-f173.google.com) (209.85.128.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Mar 2018 17:09:09 +0000 Received: by mail-wr0-f173.google.com with SMTP id s18so2532915wrg.9 for ; Mon, 12 Mar 2018 10:09:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=7XHlLp2AJ6Qsgms7B5sB9K7nr25qaJ/ljKAPmxhnmjU=; b=TBD5ug8ZrOdrsGcNLYo5tofw9/UjVz2wlPbdpCLllNG8NYquN4eywtO1htnGehqWqa zRBxuWX+7azGii62Y9STXGzs0Fvm5jC8fWtko9d4ROMnOqBU8u2pzwOPco3ungCCnwKi psAg+9+ODl7T1/zO/ucRie/Ue6g93UFGKaGaHiwctI816fmB9W3pp4ALYFjn4UfJFrOF +o7TthJcJILic52z990vzu0WYpX8DdqsfD61uTEPfNjYDOwuQwCeMIvtYnticIjmcJLh OkQ8NbLQM+JdRU88GlMpA9jNvfA3ozHo+1V1sNeRbjK0RnDoboebyrSmkaW0ORJv/Pmy NqTg== X-Gm-Message-State: AElRT7GaYMGDhR4UUTLdM3n1uGdOk0bbABnt3kugarTMCYqIE7PkwjSf C5nFQCQq2o9mr9FWQbGJO/gSmy40 X-Google-Smtp-Source: AG47ELvl9/gX0glau1/T0jv3VhbdJ1skq/h6S7Rt2j9jZbQmdxxVK/zwXxzQq5ZnJrDu2egVCQIavQ== X-Received: by 10.223.146.230 with SMTP id 93mr5657425wrn.241.1520874547206; Mon, 12 Mar 2018 10:09:07 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id s78sm14304088wrc.93.2018.03.12.10.09.06 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 12 Mar 2018 10:09:06 -0700 (PDT) From: Yao Qi To: Simon Marchi Cc: Simon Marchi , Subject: Re: [PATCH] Make arm_record_test work on big-endian machines References: <20180312030943.32669-1-simon.marchi@polymtl.ca> <86tvtle5wo.fsf@gmail.com> Date: Mon, 12 Mar 2018 17:09:00 -0000 In-Reply-To: (Simon Marchi's message of "Mon, 12 Mar 2018 11:41:34 -0400") Message-ID: <86po49dxw3.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00254.txt.bz2 Simon Marchi writes: > What do you think about the patch below? Functionally, it should be iden= tical > to what you suggested, but I think it's clear to fix extract_arm_insn ins= tead. > Patch looks good to me. Thanks. > + > + insn_record->arm_insn > + =3D (uint32_t) extract_unsigned_integer (&buf[0], 2, endian); > + > + if (insn_size =3D=3D 4) > + { > + insn_record->arm_insn <<=3D 16; > + insn_record->arm_insn > + |=3D (uint32_t) extract_unsigned_integer (&buf[2], 2, endian); Better to add some comments here. --=20 Yao (=E9=BD=90=E5=B0=A7)