From: Yao Qi <qiyaoltc@gmail.com>
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>,
Subject: Re: [PATCH] Remove MAX_REGISTER_SIZE from target.c
Date: Fri, 24 Mar 2017 15:59:00 -0000 [thread overview]
Message-ID: <86o9wqu0md.fsf@gmail.com> (raw)
In-Reply-To: <BA5146DE-FFC0-41C7-93EA-7AB1498E8AE7@arm.com> (Alan Hayward's message of "Fri, 24 Mar 2017 15:22:44 +0000")
Alan Hayward <Alan.Hayward@arm.com> writes:
Hi Alan,
Patch is good to me, a nit below,
> + int i, size = register_size (gdbarch, regno);
move "int i" ...
> + gdb_byte *buf = register_buffer (regcache, regno);
> +
> + fprintf_unfiltered (gdb_stdlog, " = ");
> + for (i = 0; i < size; i++)
... here, for (int i = 0; ....
--
Yao (齐尧)
prev parent reply other threads:[~2017-03-24 15:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 10:09 Alan Hayward
2017-03-01 17:23 ` Yao Qi
2017-03-24 15:23 ` Alan Hayward
2017-03-24 15:59 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86o9wqu0md.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=Alan.Hayward@arm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox