From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98360 invoked by alias); 24 Mar 2017 15:59:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 98347 invoked by uid 89); 24 Mar 2017 15:59:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pg0-f47.google.com Received: from mail-pg0-f47.google.com (HELO mail-pg0-f47.google.com) (74.125.83.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Mar 2017 15:59:26 +0000 Received: by mail-pg0-f47.google.com with SMTP id g2so3048008pge.3 for ; Fri, 24 Mar 2017 08:59:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=5ZRxY+Fv6DkoodfRO7aY1RwjFg10N0bQn9U1/q6zuqk=; b=LU7R3S0GqsSxUjy0mteSVWkQi7DGHqNbkBgol93qoFWMfUlMjaUkbYL0SdMVQ6ztiv yQs9pAraPy9ZCwIKrkuXkf+0kXC62JRFDx20Xaz2OT08GSW94sW+US6SdsAxBJugV3cH NazMgVCUtU3+x8xR9tJTYOqZFE4GZJlzsIf35P08WzS2h1Tr8UzzHZSaIXpV3eh0tlTt lOXnbpFg57HtEWLUtiUOJTIkOi3QWT+OmKa2LKlhUDUp1U5sZ9+03g9pDadB3M+wEnhu SxoI+HmUh7Jz2j8w8VrtbAuKljjEpGKXHDHV/LIm1GqDamchnvTByBdCuM4rSa/o6t2Y Uahw== X-Gm-Message-State: AFeK/H3Eeh8AYXQQ266SDAVPUWweLR+b/X6UBQ2DnbzaTov9z/ommw0U7RyVgH+8ZTOiMw== X-Received: by 10.98.53.7 with SMTP id c7mr9909593pfa.175.1490371166387; Fri, 24 Mar 2017 08:59:26 -0700 (PDT) Received: from E107787-LIN (gcc114.osuosl.org. [140.211.9.72]) by smtp.gmail.com with ESMTPSA id 123sm5568574pgh.21.2017.03.24.08.59.24 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 24 Mar 2017 08:59:25 -0700 (PDT) From: Yao Qi To: Alan Hayward Cc: "gdb-patches\@sourceware.org" , Subject: Re: [PATCH] Remove MAX_REGISTER_SIZE from target.c References: <868toorjwz.fsf@gmail.com> Date: Fri, 24 Mar 2017 15:59:00 -0000 In-Reply-To: (Alan Hayward's message of "Fri, 24 Mar 2017 15:22:44 +0000") Message-ID: <86o9wqu0md.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg00448.txt.bz2 Alan Hayward writes: Hi Alan, Patch is good to me, a nit below, > + int i, size =3D register_size (gdbarch, regno); move "int i" ... > + gdb_byte *buf =3D register_buffer (regcache, regno); > + > + fprintf_unfiltered (gdb_stdlog, " =3D "); > + for (i =3D 0; i < size; i++) ... here, for (int i =3D 0; .... --=20 Yao (=E9=BD=90=E5=B0=A7)