From: Eli Zaretskii <eliz@gnu.org>
To: Tom de Vries <tdevries@suse.de>, DJ Delorie <dj@delorie.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] [gdb/config/djgpp] Make djcheck.sh and djconfig.sh shellcheck-clean
Date: Tue, 01 Sep 2026 16:05:24 +0300 [thread overview]
Message-ID: <86o6eh6s17.fsf@gnu.org> (raw)
In-Reply-To: <20260901073626.2862612-1-tdevries@suse.de> (message from Tom de Vries on Tue, 1 Sep 2026 09:36:26 +0200)
> From: Tom de Vries <tdevries@suse.de>
> Date: Tue, 1 Sep 2026 09:36:26 +0200
>
> Make gdb/config/djgpp/{djcheck.sh,djconfig.sh} shellcheck-clean:
> - add missing quotes
> - add "|| exit 1" after cd
> - use printf instead of echo -n
> - disable SC2016 for "configure --prefix='${DJDIR}' assuming ${DJDIR} is
> indeed not meant to be expanded
>
> Add a .shellcheckrc to disable SC2006 to allow legacy backticked `...`.
>
> I don't have a djgpp setup, so I can't test this.
>
> Changes in v2:
> - disable SC2006
>
> Versions:
> - v1 https://sourceware.org/pipermail/gdb-patches/2026-August/229858.html
> ---
> gdb/config/djgpp/.shellcheckrc | 4 ++
> gdb/config/djgpp/djcheck.sh | 18 ++++----
> gdb/config/djgpp/djconfig.sh | 75 +++++++++++++++++-----------------
> gdb/contrib/shellcheck.sh | 4 +-
> 4 files changed, 52 insertions(+), 49 deletions(-)
> create mode 100644 gdb/config/djgpp/.shellcheckrc
Thanks. This basically encloses various file names in quotes to cater
to whitespace and other special characters, AFAICT, so it's trivially
okay.
DJ, if you can spare a moment to look over this, I'd appreciate.
Approved-By: Eli Zaretskii <eliz@gnu.org>
prev parent reply other threads:[~2026-09-01 13:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 7:36 Tom de Vries
2026-09-01 13:05 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86o6eh6s17.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dj@delorie.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox