From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aBiSB7vNlmo11BoAWB0awg (envelope-from ) for ; Tue, 01 Sep 2026 09:06:03 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=fU2J/+aK; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 073CA1E033; Tue, 01 Sep 2026 09:06:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 061811E033 for ; Tue, 01 Sep 2026 09:06:02 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A257A4BA2E0E for ; Tue, 1 Sep 2026 13:06:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A257A4BA2E0E Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=fU2J/+aK Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id ACEC94BA2E0E for ; Tue, 1 Sep 2026 13:05:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ACEC94BA2E0E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ACEC94BA2E0E Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788267928; cv=none; b=yCPbzY8h3m3M8WqlQUm4BzlYhQIpj4wAP5JN2GCIE3aVe6Xhwz1lo85n1rthCiIPxJvWGzKMynedLD4YYNfNMFbh2XCOJhjgG+rvwtBdZtXcDoRABr7X+aAJqkqT8F5z5j2BiU+P3Y+5GFx3Lkj9eudd8i+cO4BXQJIPmXmrPcQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788267928; c=relaxed/simple; bh=LBe6defQ0HRYetMJt3kcegei70ctMpXAZBtjK/rqvsE=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=icduSt7+iC75OVdAdlecLEo05J0fyguhhWomNhjHpVJr3g/trBuv5wCpJnHYVAC41bDlxMRQXV/bXe5jKpP2AFT0hMK5zaPAxLFWhfs0xHAVnxqvj0he7IPEpBKiUDoKYPE8iRoXx2Oi1HQxTbK2UK46N3TTFmrw4gt6WKJ5pGw= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=fU2J/+aK DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ACEC94BA2E0E Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x1OB4-0004nM-Bq; Tue, 01 Sep 2026 09:05:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=BH72fJfhZyjbIxNpqIN2WZLLUpTe83yTEE/1ExO638k=; b=fU2J/+aKlqtF ETcw0/fWHmDRWPAZT6uw9wQTVmJfocCVrweBL/oblUS5NdE3cnYvEju6wkd1sB/knp9pDOKGULt7w E86HfVdM5UcSuJH09k24+FgbVsajkRfwgo3mwaIDeHPLHQ4ZOkZbzvXU58LbWDcBFBnpM1vq4xMBJ vGwPehlCJD8SqtVkJ8Tu+qeV5MJQOgNTXIMkc8UqhtQypoIDkgkf2Afc7gjPI2bA5pWUo56x2Dxt0 uMK3LYAsxoQL3LNXQh+XdG1JpO3HAILFNBJX3Rn1Eyz+nv3rY2OcJVfmfkIUT67+UPTvawPHLWq6Y J4cc3RzEjvqFRSfqxQ9Ztw==; Date: Tue, 01 Sep 2026 16:05:24 +0300 Message-Id: <86o6eh6s17.fsf@gnu.org> From: Eli Zaretskii To: Tom de Vries , DJ Delorie Cc: gdb-patches@sourceware.org In-Reply-To: <20260901073626.2862612-1-tdevries@suse.de> (message from Tom de Vries on Tue, 1 Sep 2026 09:36:26 +0200) Subject: Re: [PATCH v2] [gdb/config/djgpp] Make djcheck.sh and djconfig.sh shellcheck-clean References: <20260901073626.2862612-1-tdevries@suse.de> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: Tom de Vries > Date: Tue, 1 Sep 2026 09:36:26 +0200 > > Make gdb/config/djgpp/{djcheck.sh,djconfig.sh} shellcheck-clean: > - add missing quotes > - add "|| exit 1" after cd > - use printf instead of echo -n > - disable SC2016 for "configure --prefix='${DJDIR}' assuming ${DJDIR} is > indeed not meant to be expanded > > Add a .shellcheckrc to disable SC2006 to allow legacy backticked `...`. > > I don't have a djgpp setup, so I can't test this. > > Changes in v2: > - disable SC2006 > > Versions: > - v1 https://sourceware.org/pipermail/gdb-patches/2026-August/229858.html > --- > gdb/config/djgpp/.shellcheckrc | 4 ++ > gdb/config/djgpp/djcheck.sh | 18 ++++---- > gdb/config/djgpp/djconfig.sh | 75 +++++++++++++++++----------------- > gdb/contrib/shellcheck.sh | 4 +- > 4 files changed, 52 insertions(+), 49 deletions(-) > create mode 100644 gdb/config/djgpp/.shellcheckrc Thanks. This basically encloses various file names in quotes to cater to whitespace and other special characters, AFAICT, so it's trivially okay. DJ, if you can spare a moment to look over this, I'd appreciate. Approved-By: Eli Zaretskii