From: Yao Qi <qiyaoltc@gmail.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix two misleading indentation warnings
Date: Fri, 29 Jan 2016 13:57:00 -0000 [thread overview]
Message-ID: <86mvropjyo.fsf@gmail.com> (raw)
In-Reply-To: <1454006626-10564-1-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Thu, 28 Jan 2016 13:43:46 -0500")
Simon Marchi <simon.marchi@ericsson.com> writes:
Hi Simon,
> diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
> index c7da618..4ac4191 100644
> --- a/gdb/aarch64-tdep.c
> +++ b/gdb/aarch64-tdep.c
> @@ -3199,8 +3199,8 @@ aarch64_record_asimd_load_store (insn_decode_record *aarch64_insn_r)
> record_buf_mem[mem_index++] = esize / 8;
> record_buf_mem[mem_index++] = address + addr_offset;
> }
> - addr_offset = addr_offset + (esize / 8);
> - reg_rt = (reg_rt + 1) % 32;
> + addr_offset = addr_offset + (esize / 8);
> + reg_rt = (reg_rt + 1) % 32;
> }
> }
It is a bug. The code here is to record the Advanced SIMD instructions
which load/store multiple elements into multiple registers. So the
"reg_rt" should be updated in each iteration, and we should write these
two lines into the "for" loop body.
Do you want me to fix that or you want to adjust your patch and fix it
by yourself? Either is OK to me.
--
Yao (齐尧)
next prev parent reply other threads:[~2016-01-29 13:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 18:43 Simon Marchi
2016-01-29 13:57 ` Yao Qi [this message]
2016-01-29 15:47 ` Simon Marchi
2016-01-29 17:47 ` Yao Qi
2016-01-29 20:33 ` Simon Marchi
2016-01-29 14:08 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86mvropjyo.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox