From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124131 invoked by alias); 29 Jan 2016 13:57:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124119 invoked by uid 89); 29 Jan 2016 13:57:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pf0-f181.google.com Received: from mail-pf0-f181.google.com (HELO mail-pf0-f181.google.com) (209.85.192.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 29 Jan 2016 13:57:12 +0000 Received: by mail-pf0-f181.google.com with SMTP id x125so42967772pfb.0 for ; Fri, 29 Jan 2016 05:57:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type :content-transfer-encoding; bh=er+MbZ5pQFCuIuG6PBtaJvMDe0ktdgqz7vdm2tb3ayE=; b=B3DOZnP5HDA+O/wNWZuM6xXf67YB6FPHY4vlkyhdlVsbyxwyaHtIrhHA26HeBquIL1 zxJt1/AKpzaXntKOK0Sh31sWZOe0izvN65PykFcgABRTmAj2KXj5uFWDCzu0mF0Zn3mO f4l4MyFQeDmV/aUBV5DUleyqCIfVXdhQq1isM1EVvWH48f6Ij5t9iYsQgDaoWTbGDtNq lZFE5Z+EArVN2LwnxNBW1eLfwmtoJRa8Yy9qPWNvZM5xQmmMn6t6jrzSfjBd5HchE9BP KudBfdyiVTVA++V6YRvGOghxcsDMwZpsftnzAvxC5MRTSxPu+Jnrka+VOEJxQW+Y3IDT 7Rjw== X-Gm-Message-State: AG10YOSaUoA0onDx62y6nFWGLHycEHQTWeOUbCwH+XRBQT8vGgcNQHv3fYN1LzOt3rFN/g== X-Received: by 10.98.79.140 with SMTP id f12mr13671730pfj.102.1454075830134; Fri, 29 Jan 2016 05:57:10 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id e1sm23950548pas.1.2016.01.29.05.57.07 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 29 Jan 2016 05:57:09 -0800 (PST) From: Yao Qi To: Simon Marchi Cc: Subject: Re: [PATCH] Fix two misleading indentation warnings References: <1454006626-10564-1-git-send-email-simon.marchi@ericsson.com> Date: Fri, 29 Jan 2016 13:57:00 -0000 In-Reply-To: <1454006626-10564-1-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Thu, 28 Jan 2016 13:43:46 -0500") Message-ID: <86mvropjyo.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00720.txt.bz2 Simon Marchi writes: Hi Simon, > diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c > index c7da618..4ac4191 100644 > --- a/gdb/aarch64-tdep.c > +++ b/gdb/aarch64-tdep.c > @@ -3199,8 +3199,8 @@ aarch64_record_asimd_load_store (insn_decode_record= *aarch64_insn_r) > record_buf_mem[mem_index++] =3D esize / 8; > record_buf_mem[mem_index++] =3D address + addr_offset; > } > - addr_offset =3D addr_offset + (esize / 8); > - reg_rt =3D (reg_rt + 1) % 32; > + addr_offset =3D addr_offset + (esize / 8); > + reg_rt =3D (reg_rt + 1) % 32; > } > } It is a bug. The code here is to record the Advanced SIMD instructions which load/store multiple elements into multiple registers. So the "reg_rt" should be updated in each iteration, and we should write these two lines into the "for" loop body. Do you want me to fix that or you want to adjust your patch and fix it by yourself? Either is OK to me. --=20 Yao (=E9=BD=90=E5=B0=A7)