From: Yao Qi <qiyaoltc@gmail.com>
To: Andreas Arnez <arnez@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: breakpoint-in-ro-region.exp: Support targets stopping in mid-line after "si"
Date: Tue, 03 Mar 2015 12:25:00 -0000 [thread overview]
Message-ID: <86h9u2i7yb.fsf@gmail.com> (raw)
In-Reply-To: <87bnkaxp8n.fsf@br87z6lw.de.ibm.com> (Andreas Arnez's message of "Tue, 03 Mar 2015 13:03:04 +0100")
Andreas Arnez <arnez@linux.vnet.ibm.com> writes:
> On some targets each of the assignments "i = 0" in the C source for
> "breakpoint-in-ro-region.exp" are compiled to a single instruction.
> Then each "si" stops at the beginning of the next source line. But on
> some other targets (like s390) such an assignment compiles to multiple
> instructions. Then "si" may stop in mid-line, and GDB displays the PC
> address in addition to the source line number. This was not considered
> by the regexp for this case.
Yes, they fail on aarch64-linux too.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.base/breakpoint-in-ro-region.exp (test_single_step): In the
> regexps for GDB's current line display, accept a hex address
> preceding the line number.
It looks good to me.
--
Yao (齐尧)
prev parent reply other threads:[~2015-03-03 12:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 12:03 Andreas Arnez
2015-03-03 12:25 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86h9u2i7yb.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox