From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68606 invoked by alias); 3 Mar 2015 12:25:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68596 invoked by uid 89); 3 Mar 2015 12:25:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_FROM_URIBL_PCCC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-pa0-f41.google.com Received: from mail-pa0-f41.google.com (HELO mail-pa0-f41.google.com) (209.85.220.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 03 Mar 2015 12:25:38 +0000 Received: by pabli10 with SMTP id li10so23634274pab.13 for ; Tue, 03 Mar 2015 04:25:36 -0800 (PST) X-Received: by 10.69.25.105 with SMTP id ip9mr54472328pbd.5.1425385536787; Tue, 03 Mar 2015 04:25:36 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by mx.google.com with ESMTPSA id ep2sm825040pbc.78.2015.03.03.04.25.34 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 03 Mar 2015 04:25:36 -0800 (PST) From: Yao Qi To: Andreas Arnez Cc: gdb-patches@sourceware.org Subject: Re: breakpoint-in-ro-region.exp: Support targets stopping in mid-line after "si" References: <87bnkaxp8n.fsf@br87z6lw.de.ibm.com> Date: Tue, 03 Mar 2015 12:25:00 -0000 In-Reply-To: <87bnkaxp8n.fsf@br87z6lw.de.ibm.com> (Andreas Arnez's message of "Tue, 03 Mar 2015 13:03:04 +0100") Message-ID: <86h9u2i7yb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00073.txt.bz2 Andreas Arnez writes: > On some targets each of the assignments "i =3D 0" in the C source for > "breakpoint-in-ro-region.exp" are compiled to a single instruction. > Then each "si" stops at the beginning of the next source line. But on > some other targets (like s390) such an assignment compiles to multiple > instructions. Then "si" may stop in mid-line, and GDB displays the PC > address in addition to the source line number. This was not considered > by the regexp for this case. Yes, they fail on aarch64-linux too. > > gdb/testsuite/ChangeLog: > > * gdb.base/breakpoint-in-ro-region.exp (test_single_step): In the > regexps for GDB's current line display, accept a hex address > preceding the line number. It looks good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)