From: Yao Qi <qiyaoltc@gmail.com>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] infcmd, btrace: fix crash in 'finish' for tailcall-only frames
Date: Wed, 01 Jun 2016 08:51:00 -0000 [thread overview]
Message-ID: <86h9ddxpft.fsf@gmail.com> (raw)
In-Reply-To: <1464680165-29696-1-git-send-email-markus.t.metzger@intel.com> (Markus Metzger's message of "Tue, 31 May 2016 09:36:05 +0200")
Markus Metzger <markus.t.metzger@intel.com> writes:
Patch is good to me, nits on code format,
> + do {
"{" should be in the new line.
> + start = frame;
> +
> + frame = skip_tailcall_frames (frame);
> + if (frame == NULL)
> + break;
> +
> + frame = skip_unwritable_frames (frame);
> + if (frame == NULL)
> + break;
> + } while (start != frame);
"while" should be in the new line too. The format is documented in
https://www.gnu.org/prep/standards/standards.html#Writing-C
--
Yao (齐尧)
next prev parent reply other threads:[~2016-06-01 8:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 7:36 Markus Metzger
2016-06-01 8:51 ` Yao Qi [this message]
2016-06-01 9:04 ` Metzger, Markus T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86h9ddxpft.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox