From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18968 invoked by alias); 1 Jun 2016 08:51:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18958 invoked by uid 89); 1 Jun 2016 08:51:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=prep X-HELO: mail-pf0-f178.google.com Received: from mail-pf0-f178.google.com (HELO mail-pf0-f178.google.com) (209.85.192.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 01 Jun 2016 08:51:08 +0000 Received: by mail-pf0-f178.google.com with SMTP id 62so11243080pfd.1 for ; Wed, 01 Jun 2016 01:51:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=DR2MSznxenY25v/F0m/XI2xp3Jp5VWLifou4idUCvmU=; b=aSbH/vu90JDPGW36fosKxpxZP9EeygJbkVHeAYs6bjH7uVARFQtu2qmZSs3HBsoDfy 3QI5McLyI2OqaIYmQOnNd5h3fguLde3FXRLWP4vPF5/oh75Wy9Wwykwh4uRsOq2pfxCn 1pfcJi9pUmwtfSSo6Tz8BJc55GDtKWlw9RfUUzUUoj39aFIOWRBQDlxa3657ZZJCOjMU ishHQqM4hb2/H8r/mZqw7/60Qd77uXJxIB6MOXbmETqu+Jeul8GbMmatOJGFiQ1rclXj 0VV/NOsNlTQVBRdDN4s9jjmK0fT74g3hw4GEw/R/Q6iY/Evi4kasXzbT5USNqSvJj0cF B3nw== X-Gm-Message-State: ALyK8tLEgqwC7Db1gp1rNekcCEvNgUHD4AdrE7wgMZSXj5lpdU2R8YC+sLtlOPHzU2teeg== X-Received: by 10.98.42.73 with SMTP id q70mr6444202pfq.128.1464771066458; Wed, 01 Jun 2016 01:51:06 -0700 (PDT) Received: from E107787-LIN (gcc113.osuosl.org. [140.211.9.71]) by smtp.gmail.com with ESMTPSA id yb9sm4898879pab.42.2016.06.01.01.51.04 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 01 Jun 2016 01:51:05 -0700 (PDT) From: Yao Qi To: Markus Metzger Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] infcmd, btrace: fix crash in 'finish' for tailcall-only frames References: <1464680165-29696-1-git-send-email-markus.t.metzger@intel.com> Date: Wed, 01 Jun 2016 08:51:00 -0000 In-Reply-To: <1464680165-29696-1-git-send-email-markus.t.metzger@intel.com> (Markus Metzger's message of "Tue, 31 May 2016 09:36:05 +0200") Message-ID: <86h9ddxpft.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00009.txt.bz2 Markus Metzger writes: Patch is good to me, nits on code format, > + do { "{" should be in the new line. > + start =3D frame; > + > + frame =3D skip_tailcall_frames (frame); > + if (frame =3D=3D NULL) > + break; > + > + frame =3D skip_unwritable_frames (frame); > + if (frame =3D=3D NULL) > + break; > + } while (start !=3D frame); "while" should be in the new line too. The format is documented in https://www.gnu.org/prep/standards/standards.html#Writing-C --=20 Yao (=E9=BD=90=E5=B0=A7)