From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH OBV] Add nowarnings in gdb.base/fileio.exp
Date: Thu, 18 May 2017 08:34:00 -0000 [thread overview]
Message-ID: <86fug28sxu.fsf@gmail.com> (raw)
In-Reply-To: <684aa647-c1f4-e0cb-c4d5-04bd55463e20@redhat.com> (Pedro Alves's message of "Wed, 17 May 2017 15:17:32 +0100")
Pedro Alves <palves@redhat.com> writes:
> FWIW, I think that wrapping the offending code with
>
> #pragma diagnostics push
> #pragma diagnostics ignored "-Wnonnull"
> ... stat (NULL, ...);
> #pragma diagnostics pop
>
> would be appropriate in this case. This testcase is checking that the syscalls
> on the target map back to host I/O on the gdb side, and some targets have
> slightly non-POSIX-like system calls APIs; IMHO, it's better to see warnings
> due to such mismatches instead of potentially silently miscompiling.
The diagnostic was added in gcc 4.6. Do we require gcc 4.6 to run
testsuite? I am OK with this requirement.
--
Yao (齐尧)
next prev parent reply other threads:[~2017-05-18 8:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 13:46 Yao Qi
2017-05-17 14:17 ` Pedro Alves
2017-05-18 8:34 ` Yao Qi [this message]
2017-05-18 11:06 ` Pedro Alves
2017-05-18 11:09 ` [PATCH 3/3] gdb.base/fileio.c: Fix several -Wmaybe-uninitialized warnings Pedro Alves
2017-05-18 11:09 ` [PATCH 1/3] gdb.base/fileio.exp: Remove nowarnings Pedro Alves
2017-05-18 11:09 ` [PATCH 2/3] gdb.base/fileio.c: Fix several -Wreturn-type warnings Pedro Alves
2017-05-18 11:30 ` [PATCH OBV] Add nowarnings in gdb.base/fileio.exp Yao Qi
2017-05-18 11:51 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86fug28sxu.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox