From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28623 invoked by alias); 18 May 2017 08:34:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28606 invoked by uid 89); 18 May 2017 08:34:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=46 X-HELO: mail-pf0-f174.google.com Received: from mail-pf0-f174.google.com (HELO mail-pf0-f174.google.com) (209.85.192.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 May 2017 08:34:13 +0000 Received: by mail-pf0-f174.google.com with SMTP id 9so20435876pfj.1 for ; Thu, 18 May 2017 01:34:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=tKBbx2soiTwDvZYM5+yqw52C6tJWw9kPAtEaQ2gCsAQ=; b=D9M1nHv4x+GtUI4ld3Ym3CH0eKMn6sZzmFhnoID8v1e9WW0qTCmAeBxwDp/sHDanJj SzbtlziPS7QckZ/Zg5BeBLv5+PxSEFoaE5LqAi1PfCn49Po5MY7m1lWxDbmIpJUoc8cN yFJajdNkdvIwADtJyPbo+afvpSyxy+b+LN5uJ9TkyC8/VP1ZTEugCxHtEIWW0KCiAwWw mCZAb/Of9UKIAamVX5iXJEVMj99dZTDJSFnyrK2HQXepDRmj5LYHbpM13o1oPVnxWXek iGOxLOowze5gQtXfwlaTI9826lwR9I49PMVPkaNUsq7XiDDry0dWumCl+SNQNS2n5Dmg SL7g== X-Gm-Message-State: AODbwcAxhlIVFsKFfCb48RBSSxNWgDMxZs6nFl80ScM4RRvB9lsJbwxU lVKvqKl5LRJgL9ME X-Received: by 10.99.111.140 with SMTP id k134mr3204614pgc.20.1495096455465; Thu, 18 May 2017 01:34:15 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id z3sm8319749pfk.99.2017.05.18.01.34.13 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 18 May 2017 01:34:14 -0700 (PDT) From: Yao Qi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH OBV] Add nowarnings in gdb.base/fileio.exp References: <1495028758-13982-1-git-send-email-yao.qi@linaro.org> <684aa647-c1f4-e0cb-c4d5-04bd55463e20@redhat.com> Date: Thu, 18 May 2017 08:34:00 -0000 In-Reply-To: <684aa647-c1f4-e0cb-c4d5-04bd55463e20@redhat.com> (Pedro Alves's message of "Wed, 17 May 2017 15:17:32 +0100") Message-ID: <86fug28sxu.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00409.txt.bz2 Pedro Alves writes: > FWIW, I think that wrapping the offending code with > > #pragma diagnostics push > #pragma diagnostics ignored "-Wnonnull" > ... stat (NULL, ...); > #pragma diagnostics pop > > would be appropriate in this case. This testcase is checking that the sy= scalls > on the target map back to host I/O on the gdb side, and some targets have > slightly non-POSIX-like system calls APIs; IMHO, it's better to see warni= ngs > due to such mismatches instead of potentially silently miscompiling. The diagnostic was added in gcc 4.6. Do we require gcc 4.6 to run testsuite? I am OK with this requirement. --=20 Yao (=E9=BD=90=E5=B0=A7)