Re: [PATCH v2] gdb/amd-dbgapi-target: implement the 'interrupt' target op

[Eli Zaretskii <eliz@gnu.org>]

> From: Tankut Baris Aktemur <tankutbaris.aktemur@amd.com>
> CC: <lancelot.six@amd.com>, <eliz@gnu.org>
> Date: Tue, 12 May 2026 12:33:18 -0500
> 
> In all-stop mode, an asynchronously-resumed AMD GPU thread cannot be
> stopped using the "interrupt" command, because in that case the
> interrupt request is simply passed to the target beneath (i.e. the
> native CPU target), which does nothing since all CPU threads are
> already stopped.
> 
> Implement the 'interrupt' method of amd_dbgapi_target by using the
> 'stop' method.  Also include a test.
> 
> Approved-by: Lancelot Six <lancelot.six@amd.com> (amdgpu)
> ---
>  gdb/amd-dbgapi-target.c                     |  7 +++
>  gdb/doc/gdb.texinfo                         |  4 +-
>  gdb/testsuite/gdb.rocm/interrupt-single.cpp | 43 ++++++++++++++++++
>  gdb/testsuite/gdb.rocm/interrupt-single.exp | 48 +++++++++++++++++++++
>  4 files changed, 101 insertions(+), 1 deletion(-)
>  create mode 100644 gdb/testsuite/gdb.rocm/interrupt-single.cpp
>  create mode 100644 gdb/testsuite/gdb.rocm/interrupt-single.exp

Thanks.

> +@value{GDBN} process.  Alternatively you can resume the @acronym{AMD GPU}
                                                           ^^^^^^^^^^^^^^^^^
This should be 2 separate @acronym's.

> +thread in the background using @code{continue&} (@pxref{Background Execution})
> +and then use @code{interrupt} to stop the thread.

The documentation part is okay with this nit fixed.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>