From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id RGI5OptrA2o6/TMAWB0awg (envelope-from ) for ; Tue, 12 May 2026 14:04:11 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=XwQEvxcX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DCA5C1E067; Tue, 12 May 2026 14:04:11 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 43C5E1E067 for ; Tue, 12 May 2026 14:04:11 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 120504BAE7CF for ; Tue, 12 May 2026 18:04:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 120504BAE7CF Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=XwQEvxcX Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 7BA774BAE7CF for ; Tue, 12 May 2026 18:03:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7BA774BAE7CF Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7BA774BAE7CF Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778609015; cv=none; b=NE1yGdkXAy619l81tZqNatFHmXf8XSwOWddNluQ0OnJr/Li1TIyi4f7oLigox1lTfdt8Oh5EHQwjhVzgWC6Z1skrR+bn6JzzqtaYBcTxfvE0LkGPX9fhNZevP9FrR+RdVJ/MMnq17Pe+AMPqV93FTSCUyC1DmCgbF+sP2LK46Mk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778609015; c=relaxed/simple; bh=Y+dipAH9FUDZZhlzEjp5Vmx/7Qstkj8KyRYIHYFpPoM=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=mF8n/TlZnXzYut8OZ80IZjQCdflP9JIDjUedFQRqFVj+AN7BDi+ZJfQJH+vpzE8pJRdZ4yPUgkW3bfZkFJFD1ZFBe6ot/v884gyspKSeUzjG7zmto0oaMkWqTciVKV4wqsl24hm6h8DfkvRMG+Y1Cvj3xIOBlHQiEJ5HVG3b03U= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=XwQEvxcX DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7BA774BAE7CF Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wMrSA-0004h4-ED; Tue, 12 May 2026 14:03:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=PQerQLZNeg2v11TESH+Y2HW+tsR5pkl6PXEgoJHKUy8=; b=XwQEvxcXw42N 53GAhyOwJRoQr5PB8UNTTmZyqBL1/08MNnZl9NYX1EkBwknv23E4jTum4El0laVRnobn2U1TpZbum nwgE15gQcxu+uakp7ZQwC6WDbD2h+SsnEJcnU3rY4dbJNWr8tIYrf19hTn32K/kWaG2BTffYAz+RC ollHlCAPsTnr/4tVeNJNmbb5KZcprdAQ6GQMXih9xzQ6GTbH1mT0eser1w73F+hFj9CKB9+EPmXgw 4/OumUjtEoVZpNcAzP/2dy0d96+gYxVyeAdYGuk/gufUJdvDvEZgeJvXVmaJ2ayJPtx+i9ZmUfZYG /df3C3RS32FWPCGyZa5d6w==; Date: Tue, 12 May 2026 21:03:31 +0300 Message-Id: <86fr3wzerw.fsf@gnu.org> From: Eli Zaretskii To: Tankut Baris Aktemur Cc: gdb-patches@sourceware.org, lancelot.six@amd.com In-Reply-To: <20260512173318.2727821-1-tankutbaris.aktemur@amd.com> (message from Tankut Baris Aktemur on Tue, 12 May 2026 12:33:18 -0500) Subject: Re: [PATCH v2] gdb/amd-dbgapi-target: implement the 'interrupt' target op References: <20260512173318.2727821-1-tankutbaris.aktemur@amd.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: Tankut Baris Aktemur > CC: , > Date: Tue, 12 May 2026 12:33:18 -0500 > > In all-stop mode, an asynchronously-resumed AMD GPU thread cannot be > stopped using the "interrupt" command, because in that case the > interrupt request is simply passed to the target beneath (i.e. the > native CPU target), which does nothing since all CPU threads are > already stopped. > > Implement the 'interrupt' method of amd_dbgapi_target by using the > 'stop' method. Also include a test. > > Approved-by: Lancelot Six (amdgpu) > --- > gdb/amd-dbgapi-target.c | 7 +++ > gdb/doc/gdb.texinfo | 4 +- > gdb/testsuite/gdb.rocm/interrupt-single.cpp | 43 ++++++++++++++++++ > gdb/testsuite/gdb.rocm/interrupt-single.exp | 48 +++++++++++++++++++++ > 4 files changed, 101 insertions(+), 1 deletion(-) > create mode 100644 gdb/testsuite/gdb.rocm/interrupt-single.cpp > create mode 100644 gdb/testsuite/gdb.rocm/interrupt-single.exp Thanks. > +@value{GDBN} process. Alternatively you can resume the @acronym{AMD GPU} ^^^^^^^^^^^^^^^^^ This should be 2 separate @acronym's. > +thread in the background using @code{continue&} (@pxref{Background Execution}) > +and then use @code{interrupt} to stop the thread. The documentation part is okay with this nit fixed. Reviewed-By: Eli Zaretskii