From: Yao Qi <qiyaoltc@gmail.com>
To: James Bowman <james.bowman@ftdichip.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH, FT32] Replace hard-coded instruction patterns with macros
Date: Tue, 29 Sep 2015 12:54:00 -0000 [thread overview]
Message-ID: <86d1x175dk.fsf@gmail.com> (raw)
In-Reply-To: <CA9BBF0458F83C4F9051448B941B57D11961DBC8@glaexch3> (James Bowman's message of "Mon, 28 Sep 2015 18:28:38 +0000")
James Bowman <james.bowman@ftdichip.com> writes:
> 2015-09-28 James Bowman <james.bowman@ftdichip.com>
>
> * ft32-tdep.c: #include "opcode/ft32.h"
> Delete local macro definitions
We should mention the deleted macros here.
> (ft32_analyze_prologue): Use FT32_* macros
It is a sentence, so should be ended with ".".
Otherwise, patch looks good to me.
--
Yao (齐尧)
prev parent reply other threads:[~2015-09-29 12:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 18:29 James Bowman
2015-09-29 12:54 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86d1x175dk.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=james.bowman@ftdichip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox