From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25713 invoked by alias); 29 Sep 2015 12:54:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25535 invoked by uid 89); 29 Sep 2015 12:54:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f44.google.com Received: from mail-pa0-f44.google.com (HELO mail-pa0-f44.google.com) (209.85.220.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 29 Sep 2015 12:54:41 +0000 Received: by pablk4 with SMTP id lk4so5741360pab.3 for ; Tue, 29 Sep 2015 05:54:39 -0700 (PDT) X-Received: by 10.68.202.66 with SMTP id kg2mr20842450pbc.81.1443531279854; Tue, 29 Sep 2015 05:54:39 -0700 (PDT) Received: from E107787-LIN (power-aix.osuosl.org. [140.211.15.154]) by smtp.gmail.com with ESMTPSA id lw13sm25680547pab.29.2015.09.29.05.54.38 (version=TLS1_2 cipher=AES128-SHA256 bits=128/128); Tue, 29 Sep 2015 05:54:39 -0700 (PDT) From: Yao Qi To: James Bowman Cc: "gdb-patches\@sourceware.org" Subject: Re: [PATCH, FT32] Replace hard-coded instruction patterns with macros References: Date: Tue, 29 Sep 2015 12:54:00 -0000 In-Reply-To: (James Bowman's message of "Mon, 28 Sep 2015 18:28:38 +0000") Message-ID: <86d1x175dk.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00632.txt.bz2 James Bowman writes: > 2015-09-28 James Bowman > > * ft32-tdep.c: #include "opcode/ft32.h" > Delete local macro definitions We should mention the deleted macros here. > (ft32_analyze_prologue): Use FT32_* macros It is a sentence, so should be ended with ".". Otherwise, patch looks good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)