From: Mark Kettenis <kettenis@chello.nl>
To: "J. Johnston" <jjohnstn@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: Patch for corefile support
Date: Sat, 01 Feb 2003 13:22:00 -0000 [thread overview]
Message-ID: <86bs1wp24l.fsf@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: "J. Johnston"'s message of "Mon, 27 Jan 2003 18:05:30 -0500"
"J. Johnston" <jjohnstn@redhat.com> writes:
> The attached patch fixes a problem in gdb when a corefile is read in
> after a multithreaded application has been debugged. What happens is that
> the thread-db and lin-lwp layers are still around and run into internal
> errors.
>
> The solution is simply to unpush the thread-db ops in its mourn_inferior
> routine. If a corefile gets loaded, there is no thread-db to interfere.
> If another multi-threaded app gets loaded, the thread_db_new_objfile is
> designed to bring back the thread-db layer as needed.
>
> This fix solves another failure in the killed.exp testsuite as well.
>
> Ok to commit?
Sorry, no. AFAICT this will break debugging programs that are
statically linked against libpthread. As a minimum, this code should
check keep_thread_db before unpushing the target, but even then, I'm
not sure whether this is really OK.
Mark
next prev parent reply other threads:[~2003-02-01 13:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-27 23:05 J. Johnston
2003-02-01 13:22 ` Mark Kettenis [this message]
2003-02-01 17:00 ` Daniel Jacobowitz
2003-02-03 22:58 ` J. Johnston
2003-02-03 23:39 ` Daniel Jacobowitz
2003-02-18 17:31 ` J. Johnston
2003-06-02 19:22 ` Michael Snyder
2003-06-03 20:03 ` J. Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86bs1wp24l.fsf@elgar.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=gdb-patches@sources.redhat.com \
--cc=jjohnstn@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox