Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "J. Johnston" <jjohnstn@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: RFA: Patch for corefile support
Date: Mon, 27 Jan 2003 23:05:00 -0000	[thread overview]
Message-ID: <3E35BB3A.2020003@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 594 bytes --]

The attached patch fixes a problem in gdb when a corefile is read in
after a multithreaded application has been debugged.  What happens is that
the thread-db and lin-lwp layers are still around and run into internal
errors.

The solution is simply to unpush the thread-db ops in its mourn_inferior
routine.  If a corefile gets loaded, there is no thread-db to interfere.
If another multi-threaded app gets loaded, the thread_db_new_objfile is
designed to bring back the thread-db layer as needed.

This fix solves another failure in the killed.exp testsuite as well.

Ok to commit?

-- Jeff J.

[-- Attachment #2: thread-db.patch --]
[-- Type: text/plain, Size: 555 bytes --]

Index: thread-db.c
===================================================================
RCS file: /cvs/src/src/gdb/thread-db.c,v
retrieving revision 1.28
diff -u -r1.28 thread-db.c
--- thread-db.c	14 Jan 2003 00:49:04 -0000	1.28
+++ thread-db.c	27 Jan 2003 22:58:58 -0000
@@ -1007,6 +1007,11 @@
   proc_handle.pid = 0;
 
   target_beneath->to_mourn_inferior ();
+
+  /* Detach thread_db target ops.  The thread_db_new_objfile routine
+     will reattach them later if needed.  */
+  unpush_target (&thread_db_ops);
+  using_thread_db = 0;
 }
 
 static int

             reply	other threads:[~2003-01-27 23:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-27 23:05 J. Johnston [this message]
2003-02-01 13:22 ` Mark Kettenis
2003-02-01 17:00   ` Daniel Jacobowitz
2003-02-03 22:58     ` J. Johnston
2003-02-03 23:39       ` Daniel Jacobowitz
2003-02-18 17:31         ` J. Johnston
2003-06-02 19:22 ` Michael Snyder
2003-06-03 20:03   ` J. Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E35BB3A.2020003@redhat.com \
    --to=jjohnstn@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox