From: Yao Qi <qiyaoltc@gmail.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] PR python/15620, PR python/18620 - breakpoint events in Python
Date: Wed, 13 Jul 2016 13:40:00 -0000 [thread overview]
Message-ID: <86bn21y7vq.fsf@gmail.com> (raw)
In-Reply-To: <1463777131-7289-1-git-send-email-tom@tromey.com> (Tom Tromey's message of "Fri, 20 May 2016 14:45:31 -0600")
Tom Tromey <tom@tromey.com> writes:
Hi Tom,
Patch is good to me.
> @@ -917,6 +926,15 @@ gdbpy_breakpoint_deleted (struct breakpoint *b)
> bp_obj = bp->py_bp_object;
> if (bp_obj)
> {
> + if (!evregpy_no_listeners_p (gdb_py_events.breakpoint_deleted))
> + {
> + PyObject *bp_obj_alias = (PyObject *) bp_obj;
Nit: an empty line is needed here.
> + Py_INCREF (bp_obj_alias);
> + if (evpy_emit_event (bp_obj_alias,
> + gdb_py_events.breakpoint_deleted) < 0)
> + gdbpy_print_stack ();
> + }
> +
> bp_obj->bp = NULL;
> --bppy_live;
> Py_DECREF (bp_obj);
--
Yao (齐尧)
next prev parent reply other threads:[~2016-07-13 13:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 20:45 Tom Tromey
2016-05-20 21:18 ` Eli Zaretskii
2016-07-13 13:40 ` Yao Qi [this message]
2016-07-13 19:52 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86bn21y7vq.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox