From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45319 invoked by alias); 13 Jul 2016 13:40:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45208 invoked by uid 89); 13 Jul 2016 13:40:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pf0-f195.google.com Received: from mail-pf0-f195.google.com (HELO mail-pf0-f195.google.com) (209.85.192.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 13 Jul 2016 13:40:06 +0000 Received: by mail-pf0-f195.google.com with SMTP id g202so3176530pfb.1 for ; Wed, 13 Jul 2016 06:40:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=tHYXAyLbWLK0+/19hKu4pihqaxuwUKMkYDuB+7Th5k8=; b=mEbNrtB7CS47ChdpM83ch0YxkJRMGTqkIW/LwJGKqV9zEK+EbN30KVgnNQHQa8FYCB mDmVu3GXw7ybjcjbeqXH+dedMUGnkrii0pIEg5YSvGRZysPP1KEJT5s8qVNvhMiaSsh4 XDXxV6NlWmvXOSiarAj0a+Ng8J37nGQgZArAvWflW2SJYb+F181urxCZNLmkywjQsvXB +S4rLfXHNdbvk8yd3VvhF00PDJgwAogoHGoKRXM6vLY8vaDlZ/U5a5IPV+jdXvSGJBWQ KvBr4YnqXU+ZlBIA92HyLEWgzS0zlJXoYxylHz8ye97z6Sx1LKmOfSdbCx2XDLuVd1u8 n4aw== X-Gm-Message-State: ALyK8tLXYoMw7rlM8b2+2x8hpJx+roEQhSgVEQHQBvFkT+FXbckTOqu7QO8B3zpaT8MluA== X-Received: by 10.98.112.196 with SMTP id l187mr3601775pfc.59.1468417182164; Wed, 13 Jul 2016 06:39:42 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id k29sm6219396pfb.2.2016.07.13.06.39.39 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 13 Jul 2016 06:39:41 -0700 (PDT) From: Yao Qi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA] PR python/15620, PR python/18620 - breakpoint events in Python References: <1463777131-7289-1-git-send-email-tom@tromey.com> Date: Wed, 13 Jul 2016 13:40:00 -0000 In-Reply-To: <1463777131-7289-1-git-send-email-tom@tromey.com> (Tom Tromey's message of "Fri, 20 May 2016 14:45:31 -0600") Message-ID: <86bn21y7vq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-07/txt/msg00146.txt.bz2 Tom Tromey writes: Hi Tom, Patch is good to me. > @@ -917,6 +926,15 @@ gdbpy_breakpoint_deleted (struct breakpoint *b) > bp_obj =3D bp->py_bp_object; > if (bp_obj) > { > + if (!evregpy_no_listeners_p (gdb_py_events.breakpoint_deleted)) > + { > + PyObject *bp_obj_alias =3D (PyObject *) bp_obj; Nit: an empty line is needed here. > + Py_INCREF (bp_obj_alias); > + if (evpy_emit_event (bp_obj_alias, > + gdb_py_events.breakpoint_deleted) < 0) > + gdbpy_print_stack (); > + } > + > bp_obj->bp =3D NULL; > --bppy_live; > Py_DECREF (bp_obj); --=20 Yao (=E9=BD=90=E5=B0=A7)