Re: [PATCH 1/2] RISC-V GDB Port

[Yao Qi <qiyaoltc@gmail.com>]

Palmer Dabbelt <palmer@dabbelt.com> writes:

Hi,
I have some time today, so I can review the patch.

>  gdb/Makefile.in                 |    5 +
>  gdb/config/riscv/linux.mh       |   30 +
>  gdb/features/Makefile           |    2 +
>  gdb/features/riscv.c            |   86 +++
>  gdb/features/riscv.xml          |   81 +++
>  gdb/gdbserver/linux-riscv-low.c |  221 +++++++
>  gdb/regformats/riscv.dat        |   69 ++
>  gdb/riscv-linux-nat.c           |   77 +++
>  gdb/riscv-linux-tdep.c          |   80 +++
>  gdb/riscv-linux-tdep.h          |   30 +
>  gdb/riscv-tdep.c                | 1368 +++++++++++++++++++++++++++++++++++++++
>  gdb/riscv-tdep.h                |   96 +++
>  include/gdb/sim-riscv.h         |   98 +++

Before I read the patch further, my suggestion is to split your patch
to following parts next time,

 - bare metal support, riscv-tdep.c
 - linux target support, riscv-linux-tdep.c,
 - linux host support, riscv-linux-nat.c,
 - gdbserver support, gdbserver/linux-riscv-low.c
 - target description,

I am surprised that there is no change to gdb/testsuite/.

-- 
Yao (齐尧)