From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95863 invoked by alias); 4 Apr 2017 21:48:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95754 invoked by uid 89); 4 Apr 2017 21:48:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=Port, Hx-languages-length:970, metal X-HELO: mail-wm0-f67.google.com Received: from mail-wm0-f67.google.com (HELO mail-wm0-f67.google.com) (74.125.82.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Apr 2017 21:48:27 +0000 Received: by mail-wm0-f67.google.com with SMTP id o81so7980674wmb.0 for ; Tue, 04 Apr 2017 14:48:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=smNbDcdtDtgp/nfEJX6Brgj1DGWbGTvnJUqe4xo36CE=; b=hsfIZ0OPf2mQJR41nYi15gOYL076ufk/gsZx+Ak93N0Kjvg+naZ8yTSuPQd8L2bQYm o/PpyDGt/LpE+LKqfaI4EEuWn5wJ7wiSHejvyxjbdkuZwJHOCLL7+KfjLWJRjZMJK2fX pphPiy2fyujdIdSFkXpnXmwRahTof1jbfUcIh+DBhGn4H+tJ/bT68RjKoDAMYegGyhnW 5z7UnCXPiS0WeViORp/MD3hGgoOENtQJyAnBcojo9bYDGlnEMkHl0VUaeo7H5xuQmjz5 abbllxeMaa3tiMPUu8Onc7Llms5fyEouZ8Nc416vRQ2eH2LQwkOFC5Sxoek0d1BDrOvK QWPg== X-Gm-Message-State: AFeK/H226nrCKSiw2X+uhNNFTcCl9bR9hUfNCnFh5hci1flcqfdR52ENDMj9Z+/eTCHnPg== X-Received: by 10.28.156.140 with SMTP id f134mr16031289wme.40.1491342506877; Tue, 04 Apr 2017 14:48:26 -0700 (PDT) Received: from E107787-LIN ([194.214.185.158]) by smtp.gmail.com with ESMTPSA id t68sm23815825wrc.55.2017.04.04.14.48.25 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 04 Apr 2017 14:48:26 -0700 (PDT) From: Yao Qi To: Palmer Dabbelt Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] RISC-V GDB Port References: <20170307043029.3672-1-palmer@dabbelt.com> <20170307043029.3672-2-palmer@dabbelt.com> Date: Tue, 04 Apr 2017 21:48:00 -0000 In-Reply-To: <20170307043029.3672-2-palmer@dabbelt.com> (Palmer Dabbelt's message of "Mon, 6 Mar 2017 20:30:28 -0800") Message-ID: <86a87v6dzr.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00076.txt.bz2 Palmer Dabbelt writes: Hi, I have some time today, so I can review the patch. > gdb/Makefile.in | 5 + > gdb/config/riscv/linux.mh | 30 + > gdb/features/Makefile | 2 + > gdb/features/riscv.c | 86 +++ > gdb/features/riscv.xml | 81 +++ > gdb/gdbserver/linux-riscv-low.c | 221 +++++++ > gdb/regformats/riscv.dat | 69 ++ > gdb/riscv-linux-nat.c | 77 +++ > gdb/riscv-linux-tdep.c | 80 +++ > gdb/riscv-linux-tdep.h | 30 + > gdb/riscv-tdep.c | 1368 +++++++++++++++++++++++++++++++++= ++++++ > gdb/riscv-tdep.h | 96 +++ > include/gdb/sim-riscv.h | 98 +++ Before I read the patch further, my suggestion is to split your patch to following parts next time, - bare metal support, riscv-tdep.c - linux target support, riscv-linux-tdep.c, - linux host support, riscv-linux-nat.c, - gdbserver support, gdbserver/linux-riscv-low.c - target description, I am surprised that there is no change to gdb/testsuite/. --=20 Yao (=E9=BD=90=E5=B0=A7)