From: Yao Qi <qiyaoltc@gmail.com>
To: Antoine Tremblay <antoine.tremblay@ericsson.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH v3 06/10] Replace breakpoint_reinsert_addr by get_next_pcs operation in GDBServer.
Date: Thu, 26 Nov 2015 10:30:00 -0000 [thread overview]
Message-ID: <868u5lxdct.fsf@gmail.com> (raw)
In-Reply-To: <1448287968-12907-7-git-send-email-antoine.tremblay@ericsson.com> (Antoine Tremblay's message of "Mon, 23 Nov 2015 09:12:44 -0500")
Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
> gdb/gdbserver/ChangeLog:
> * linux-aarch64-low.c (struct linux_target_ops): Rename
> breakpoint_reinsert_addr to get_next_pcs.
Nit: the change is to the_low_target, not "struct linux_target_ops", so
it should be
* linux-aarch64-low.c (the_low_target): ....
> * linux-arm-low.c (struct linux_target_ops): Likewise.
> * linux-bfin-low.c (struct linux_target_ops): Likewise.
> * linux-cris-low.c (struct linux_target_ops): Likewise.
> * linux-crisv32-low.c (struct linux_target_ops): Likewise.
> * linux-low.c (can_software_single_step): Likewise.
> (install_software_single_step_breakpoints): New function.
> (start_step_over): Use install_software_single_step_breakpoints.
> * linux-low.h: New CORE_ADDR vector.
> (struct linux_target_ops) Rename breakpoint_reinsert_addr to
> get_next_pcs.
> * linux-mips-low.c (struct linux_target_ops): Likewise.
> * linux-nios2-low.c (struct linux_target_ops): Likewise.
> * linux-sparc-low.c (struct linux_target_ops): Likewise.
Patch is good to me.
--
Yao (齐尧)
next prev parent reply other threads:[~2015-11-26 10:30 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 14:14 [PATCH v3 0/10] Support software single step and conditional breakpoints on ARM " Antoine Tremblay
2015-11-23 14:14 ` [PATCH v3 09/10] Enable software single stepping for while-stepping actions " Antoine Tremblay
2015-11-23 14:14 ` [PATCH v3 02/10] Fix instruction skipping when using software single step " Antoine Tremblay
2015-11-23 14:14 ` [PATCH v3 04/10] Remove support for thread events without PTRACE_EVENT_CLONE " Antoine Tremblay
2015-11-25 16:48 ` Yao Qi
2015-11-25 17:42 ` Antoine Tremblay
2015-11-23 14:14 ` [PATCH v3 05/10] Remove too simple breakpoint_reinsert_addr implementations Antoine Tremblay
2015-11-23 14:14 ` [PATCH v3 06/10] Replace breakpoint_reinsert_addr by get_next_pcs operation in GDBServer Antoine Tremblay
2015-11-26 10:30 ` Yao Qi [this message]
2015-11-26 13:48 ` Antoine Tremblay
2015-11-26 10:50 ` Pedro Alves
2015-11-26 13:50 ` Antoine Tremblay
2015-11-23 14:14 ` [PATCH v3 01/10] Fix breakpoint size when stepping over a permanent breakpoint " Antoine Tremblay
2015-11-23 14:14 ` [PATCH v3 03/10] Refactor queries for hardware and software single stepping support " Antoine Tremblay
2015-11-23 14:14 ` [PATCH v3 07/10] Share some ARM target dependant code from GDB with GDBServer Antoine Tremblay
2015-11-25 17:01 ` Yao Qi
2015-11-26 10:38 ` Yao Qi
2015-11-26 13:56 ` Antoine Tremblay
2015-11-23 14:15 ` [PATCH v3 08/10] Support software single step on ARM in GDBServer Antoine Tremblay
2015-11-26 10:49 ` Pedro Alves
2015-11-26 13:35 ` Antoine Tremblay
2015-11-26 12:48 ` Yao Qi
2015-11-26 15:12 ` Antoine Tremblay
2015-11-26 16:04 ` Yao Qi
2015-11-26 16:07 ` Antoine Tremblay
2015-11-27 13:45 ` Antoine Tremblay
2015-11-27 15:15 ` Yao Qi
2015-11-27 15:35 ` Antoine Tremblay
2015-11-23 14:15 ` [PATCH v3 10/10] Enable conditional breakpoints for targets that support software single step " Antoine Tremblay
2015-11-26 10:25 ` Yao Qi
2015-11-26 15:34 ` Antoine Tremblay
2015-12-03 9:50 ` Yao Qi
2015-11-27 9:27 ` [PATCH v3 0/10] Support software single step and conditional breakpoints on ARM " Yao Qi
2015-11-27 13:16 ` Antoine Tremblay
2015-11-30 20:21 ` Antoine Tremblay
2015-12-01 9:33 ` Yao Qi
2015-12-01 13:00 ` Antoine Tremblay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868u5lxdct.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox