From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55217 invoked by alias); 26 Nov 2015 10:30:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55154 invoked by uid 89); 26 Nov 2015 10:30:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f48.google.com Received: from mail-pa0-f48.google.com (HELO mail-pa0-f48.google.com) (209.85.220.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 26 Nov 2015 10:30:00 +0000 Received: by pacdm15 with SMTP id dm15so83277977pac.3 for ; Thu, 26 Nov 2015 02:29:59 -0800 (PST) X-Received: by 10.98.75.71 with SMTP id y68mr38725409pfa.75.1448533799065; Thu, 26 Nov 2015 02:29:59 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id rn7sm27138431pab.23.2015.11.26.02.29.57 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 26 Nov 2015 02:29:58 -0800 (PST) From: Yao Qi To: Antoine Tremblay Cc: Subject: Re: [PATCH v3 06/10] Replace breakpoint_reinsert_addr by get_next_pcs operation in GDBServer. References: <1448287968-12907-1-git-send-email-antoine.tremblay@ericsson.com> <1448287968-12907-7-git-send-email-antoine.tremblay@ericsson.com> Date: Thu, 26 Nov 2015 10:30:00 -0000 In-Reply-To: <1448287968-12907-7-git-send-email-antoine.tremblay@ericsson.com> (Antoine Tremblay's message of "Mon, 23 Nov 2015 09:12:44 -0500") Message-ID: <868u5lxdct.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00541.txt.bz2 Antoine Tremblay writes: > gdb/gdbserver/ChangeLog: > * linux-aarch64-low.c (struct linux_target_ops): Rename > breakpoint_reinsert_addr to get_next_pcs. Nit: the change is to the_low_target, not "struct linux_target_ops", so it should be * linux-aarch64-low.c (the_low_target): .... > * linux-arm-low.c (struct linux_target_ops): Likewise. > * linux-bfin-low.c (struct linux_target_ops): Likewise. > * linux-cris-low.c (struct linux_target_ops): Likewise. > * linux-crisv32-low.c (struct linux_target_ops): Likewise. > * linux-low.c (can_software_single_step): Likewise. > (install_software_single_step_breakpoints): New function. > (start_step_over): Use install_software_single_step_breakpoints. > * linux-low.h: New CORE_ADDR vector. > (struct linux_target_ops) Rename breakpoint_reinsert_addr to > get_next_pcs. > * linux-mips-low.c (struct linux_target_ops): Likewise. > * linux-nios2-low.c (struct linux_target_ops): Likewise. > * linux-sparc-low.c (struct linux_target_ops): Likewise. Patch is good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)