From: Yao Qi <qiyaoltc@gmail.com>
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>,
nd <nd@arm.com>
Subject: Re: [PATCH] commonize AARCH64 REGNUM/REGNO defines
Date: Tue, 24 Oct 2017 15:47:00 -0000 [thread overview]
Message-ID: <868tg05z0j.fsf@gmail.com> (raw)
In-Reply-To: <F790664E-11CC-4AA4-9F73-A14F5D9E2152@arm.com> (Alan Hayward's message of "Tue, 24 Oct 2017 14:18:29 +0000")
Alan Hayward <Alan.Hayward@arm.com> writes:
Patch is good to me, some nits below,
> +#ifndef AARCH64_H
#ifndef ARCH_AARCH64_H
I know other arch/*.h don't follow this, but they should be fixed.
> +#define AARCH64_H
> +
> +
> +#endif /* aarch64.h */
/* ARCH_AARCH64_H */
> \ No newline at end of file
Add a new line at the end.
--
Yao (齐尧)
next prev parent reply other threads:[~2017-10-24 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 14:18 Alan Hayward
2017-10-24 15:47 ` Yao Qi [this message]
2017-10-25 8:10 ` Alan Hayward
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868tg05z0j.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=Alan.Hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox