From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60972 invoked by alias); 24 Oct 2017 15:47:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60898 invoked by uid 89); 24 Oct 2017 15:47:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=*h, H*r:sk:static. X-HELO: mail-wm0-f44.google.com Received: from mail-wm0-f44.google.com (HELO mail-wm0-f44.google.com) (74.125.82.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Oct 2017 15:47:14 +0000 Received: by mail-wm0-f44.google.com with SMTP id b189so16496973wmd.4 for ; Tue, 24 Oct 2017 08:47:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=e8NMvc9su2sanCqzWqEZLX50toONqT+zdanxEaxLRlc=; b=NZF81+bpiFnXjLwSiQSp9pG/o2zuBdHiu7uihrlMi5cV7DzNFlT7D0Ti4gFgBjWYjZ l3G5qG2yM1n9L7hYGqsqo6fueXgPydXLOwBYK+hBpCnZdFAkZ0ualh961gQ8wMqBwTvE LUVW9kRYx9k8jwW/dUQnbgD2+6KLg1qoprV+82oh0xVxxOa0mMhoGLmw1QFNsK3bKmUU eqcl9WL2eIMXVNolEDmdgVdI9LpIrM/EZw5kV4hRPxm1tE/NKUKZNOuqL2suqxLzgHNX yQBzcAphCJttCOXnN2LNPmQwmO0b86X11dfib4NsWCPgnANlZjytc2CbyD+3viKSb47A sOyA== X-Gm-Message-State: AMCzsaW/FROCxersyq4V5w2GVrgjXhMiQaKUv80v29C5ds8mN/ODJ2h8 s9gusR7tu0+YvCyoskroB6o= X-Google-Smtp-Source: ABhQp+RxPjpRxQf4KUks46bDqtC2bU18nJeywZBPbe4cNAlUEat/wl/g/PbVPUf78RJDwFH5qn83WQ== X-Received: by 10.28.0.66 with SMTP id 63mr8436959wma.7.1508860032888; Tue, 24 Oct 2017 08:47:12 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id y15sm686133wrc.96.2017.10.24.08.47.11 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 24 Oct 2017 08:47:12 -0700 (PDT) From: Yao Qi To: Alan Hayward Cc: "gdb-patches\@sourceware.org" , nd Subject: Re: [PATCH] commonize AARCH64 REGNUM/REGNO defines References: Date: Tue, 24 Oct 2017 15:47:00 -0000 In-Reply-To: (Alan Hayward's message of "Tue, 24 Oct 2017 14:18:29 +0000") Message-ID: <868tg05z0j.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00748.txt.bz2 Alan Hayward writes: Patch is good to me, some nits below, > +#ifndef AARCH64_H #ifndef ARCH_AARCH64_H I know other arch/*.h don't follow this, but they should be fixed. > +#define AARCH64_H > + > + > +#endif /* aarch64.h */ /* ARCH_AARCH64_H */ > \ No newline at end of file Add a new line at the end. --=20 Yao (=E9=BD=90=E5=B0=A7)