Re: [PATCH 5/5] Add zebra-striping to CLI table display

[Eli Zaretskii <eliz@gnu.org>]

> From: Tom Tromey <tom@tromey.com>
> Date: Fri, 12 Jun 2026 08:25:25 -0600
> Cc: Tom Tromey <tom@tromey.com>
> 
> This patch adds two new style settings to gdb.  These can be used to
> add "zebra striping" to CLI tables -- that is, change the prevailing
> style of alternating lines of a table.
> 
> Modifying the CLI ui-out is sufficient for most tables.  However, this
> did not work for stack traces, because those aren't ordinary tables.
> This patch uses the "phony table" support (added earlier in this
> series) to achieve the same effect without otherwise impacting stack
> trace display.
> 
> By default, styles are only changed if 256 colors are available.  This
> way we can choose a relatively innocuous grey background.
> 
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32285
> ---
>  gdb/NEWS                               | 10 +++++
>  gdb/cli-out.c                          | 24 +++++++++--
>  gdb/cli-out.h                          | 10 +++++
>  gdb/cli/cli-style.c                    | 43 +++++++++++++++++-
>  gdb/cli/cli-style.h                    |  6 ++-
>  gdb/doc/gdb.texinfo                    |  8 ++++
>  gdb/stack.c                            |  6 +++
>  gdb/testsuite/gdb.base/style.exp       |  3 ++
>  gdb/testsuite/gdb.base/zebra-style.c   | 32 ++++++++++++++
>  gdb/testsuite/gdb.base/zebra-style.exp | 79 ++++++++++++++++++++++++++++++++++
>  gdb/testsuite/lib/gdb-utils.exp        | 14 +++---
>  gdb/ui-out.c                           |  8 +++-
>  gdb/ui-out.h                           |  2 +
>  gdb/utils.c                            |  6 +++
>  14 files changed, 238 insertions(+), 13 deletions(-)

Thanks, the documentation parts are okay.  However, maybe we should
include "table" in the names of these command?  Like "set style table
even" and "set style table odd" or something?  That'd allow us to add
more styles specific to tables in the future.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>