From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iP8EK6AiLGpSXAMAWB0awg (envelope-from ) for ; Fri, 12 Jun 2026 11:15:44 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=B7UEb6Mn; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9DFBC1E070; Fri, 12 Jun 2026 11:15:44 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9E16A1E070 for ; Fri, 12 Jun 2026 11:15:43 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5C5D34BA79AC for ; Fri, 12 Jun 2026 15:15:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5C5D34BA79AC Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=B7UEb6Mn Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id B80174BA2E32 for ; Fri, 12 Jun 2026 15:14:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B80174BA2E32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B80174BA2E32 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781277297; cv=none; b=M0Gm/LYHs6vosJjAw6zwiIgu8BJIuGNwh/DQuTc7g3vuKbRkRPumoZq+MorC52MiiWozTSccEwg/o3J6RbTaQGXGBNmDuDaI9qYEuCEozyT5t+Z85UcxlxGuHJlpIBgwQhPdhZFE5acw6xgimYHaNPkkYHUsCTGyN+dBBmZQndM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781277297; c=relaxed/simple; bh=trbhepbRc9j1I9qYI61SKyYgd1DR7JHFxwnx9F4HHVU=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=MeD2oOBJzRfF0Ghwc5Y6zMHXCLUdHMNvdImUU7R3w4MN2F+6DVQX+mKrFCzH4BDE/2qEOqUFIFsOmcFtTB62zv9grcI2St2znC6jLvSa29WR0DNoz/a7sgyIEuySwz4ObjNSTVlGO8hZFKQ1ZQe6Pa95+xHEMVyCFls0saJenQQ= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=B7UEb6Mn DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B80174BA2E32 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wY3ay-0000MN-U0; Fri, 12 Jun 2026 11:14:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2tg9yC2JlnAJQ3s0wXABxZJk71DGnZFPTrx7KYvdw2I=; b=B7UEb6Mn++bJ RJC4s+Y1y0sWwAgpXbarRsZpinEr2ZjKD75bYNqtko4wPqXMb3Rvx4uKQa2oVp5VbtRuPe0+/tP+2 KWi1/hxncvab+VNZDEh7hFGhBW03ta8OconZurCV0Eu/Hn4Mr8ZTBlVJItXVarnhxcHrftULF0y18 pFJnXtkZAU4a3qVKhSbjtmh2FrnIvIKeA5ftvOoHDwzhN5AsE66BhjJjquYuQkEGEaGhL/oKnit86 90SaSu9Yq1l9RuJ0QhRvbdIuBKu5siU6YkfaaOJQFyVqzyL2zS10xnu/qxJ7lnF/4rW6nKgS5yu1Z yih9pJkdGIt90ERTqNpSvw==; Date: Fri, 12 Jun 2026 18:14:47 +0300 Message-Id: <868q8jokns.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey Cc: gdb-patches@sourceware.org In-Reply-To: <20260612-submit-zebra-style-v1-5-cfd00b5c984c@tromey.com> (message from Tom Tromey on Fri, 12 Jun 2026 08:25:25 -0600) Subject: Re: [PATCH 5/5] Add zebra-striping to CLI table display References: <20260612-submit-zebra-style-v1-0-cfd00b5c984c@tromey.com> <20260612-submit-zebra-style-v1-5-cfd00b5c984c@tromey.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: Tom Tromey > Date: Fri, 12 Jun 2026 08:25:25 -0600 > Cc: Tom Tromey > > This patch adds two new style settings to gdb. These can be used to > add "zebra striping" to CLI tables -- that is, change the prevailing > style of alternating lines of a table. > > Modifying the CLI ui-out is sufficient for most tables. However, this > did not work for stack traces, because those aren't ordinary tables. > This patch uses the "phony table" support (added earlier in this > series) to achieve the same effect without otherwise impacting stack > trace display. > > By default, styles are only changed if 256 colors are available. This > way we can choose a relatively innocuous grey background. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32285 > --- > gdb/NEWS | 10 +++++ > gdb/cli-out.c | 24 +++++++++-- > gdb/cli-out.h | 10 +++++ > gdb/cli/cli-style.c | 43 +++++++++++++++++- > gdb/cli/cli-style.h | 6 ++- > gdb/doc/gdb.texinfo | 8 ++++ > gdb/stack.c | 6 +++ > gdb/testsuite/gdb.base/style.exp | 3 ++ > gdb/testsuite/gdb.base/zebra-style.c | 32 ++++++++++++++ > gdb/testsuite/gdb.base/zebra-style.exp | 79 ++++++++++++++++++++++++++++++++++ > gdb/testsuite/lib/gdb-utils.exp | 14 +++--- > gdb/ui-out.c | 8 +++- > gdb/ui-out.h | 2 + > gdb/utils.c | 6 +++ > 14 files changed, 238 insertions(+), 13 deletions(-) Thanks, the documentation parts are okay. However, maybe we should include "table" in the names of these command? Like "set style table even" and "set style table odd" or something? That'd allow us to add more styles specific to tables in the future. Reviewed-By: Eli Zaretskii