From: Yao Qi <qiyaoltc@gmail.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add enum for result of fast_tracepoint_collecting
Date: Wed, 26 Jul 2017 07:42:00 -0000 [thread overview]
Message-ID: <867eyvprtv.fsf@gmail.com> (raw)
In-Reply-To: <1501015878-5152-1-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Tue, 25 Jul 2017 22:51:18 +0200")
Simon Marchi <simon.marchi@ericsson.com> writes:
> /* Convenience wrapper. Returns true if LWP is presently collecting a
> fast tracepoint. */
>
The comments should be updated too.
> -static int
> +static fast_tpoint_collect_result
> linux_fast_tracepoint_collecting (struct lwp_info *lwp,
> struct fast_tpoint_collect_status *status)
> {
> diff --git a/gdb/gdbserver/linux-low.h b/gdb/gdbserver/linux-low.h
> index 6328da0..18ca6a0 100644
> --- a/gdb/gdbserver/linux-low.h
> +++ b/gdb/gdbserver/linux-low.h
> @@ -26,6 +26,7 @@
> /* Included for ptrace type definitions. */
> #include "nat/linux-ptrace.h"
> #include "target/waitstatus.h" /* For enum target_stop_reason. */
> +#include "tracepoint.h"
>
> #define PTRACE_XFER_TYPE long
>
> @@ -358,7 +359,7 @@ struct lwp_info
> return to the jump pad. Normally, we won't care about this, but
> we will if a signal arrives to this lwp while it is
> collecting. */
> - int collecting_fast_tracepoint;
> + fast_tpoint_collect_result collecting_fast_tracepoint;
The comments should be updated too.
>
> /* If this is non-zero, it points to a chain of signals which need
> to be reported to GDB. These were deferred because the thread
Otherwise, the patch is good to me.
--
Yao (齐尧)
next prev parent reply other threads:[~2017-07-26 7:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 20:51 Simon Marchi
2017-07-26 7:42 ` Yao Qi [this message]
2017-07-26 9:00 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=867eyvprtv.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox