From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93900 invoked by alias); 26 Jul 2017 07:42:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93859 invoked by uid 89); 26 Jul 2017 07:42:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Received:Wed, H*r:sk:static. X-HELO: mail-io0-f193.google.com Received: from mail-io0-f193.google.com (HELO mail-io0-f193.google.com) (209.85.223.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Jul 2017 07:42:25 +0000 Received: by mail-io0-f193.google.com with SMTP id l7so10733358iof.5 for ; Wed, 26 Jul 2017 00:42:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=02WBU4LoMJduppW0hi6/5wyQv8PiFz+W14Rs2L0Wzzo=; b=RpsYZIEx6emk4ilSLm5fcb7OTf7XViBYP+c/7qV8kj9nGrw3zmnJ7IJ2UcsMwb/ko2 hq+2ButDEdxpViaV9ygiUHs5OIkrSAs4V8chGXJZbQfy4OGf9EhukbTXhUj8VjyEUC9B u0b0S7AvFTwvC4ihHJ7X9dG7psWBbrSaI0hwnoVmIXs0I49O/mR0kXs+g25CTLb/JFJ6 40Sxihq2o/05iVdcP5pZEm4y6NBoLX76/leI84yjE2VhVk79CwwrvweiGRA5ZN7/fpFP zBou0zQuGlTy1Cztrf5k3IRt/aX7HIyw+We9KjeuwadiceWVcT1jSKlZxCis6nxNrw0e oWLA== X-Gm-Message-State: AIVw112IW2rIVdGQtzUjan53CzEKTcSWVWHWZWVW8mLE3A86Z+YNqhXz cAyTd/fUnSYo5x7P X-Received: by 10.107.51.197 with SMTP id z188mr52394ioz.195.1501054943478; Wed, 26 Jul 2017 00:42:23 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id b83sm5873800iod.35.2017.07.26.00.42.22 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 26 Jul 2017 00:42:22 -0700 (PDT) From: Yao Qi To: Simon Marchi Cc: Subject: Re: [PATCH] Add enum for result of fast_tracepoint_collecting References: <1501015878-5152-1-git-send-email-simon.marchi@ericsson.com> Date: Wed, 26 Jul 2017 07:42:00 -0000 In-Reply-To: <1501015878-5152-1-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Tue, 25 Jul 2017 22:51:18 +0200") Message-ID: <867eyvprtv.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00405.txt.bz2 Simon Marchi writes: > /* Convenience wrapper. Returns true if LWP is presently collecting a > fast tracepoint. */ >=20=20 The comments should be updated too. > -static int > +static fast_tpoint_collect_result > linux_fast_tracepoint_collecting (struct lwp_info *lwp, > struct fast_tpoint_collect_status *status) > { > diff --git a/gdb/gdbserver/linux-low.h b/gdb/gdbserver/linux-low.h > index 6328da0..18ca6a0 100644 > --- a/gdb/gdbserver/linux-low.h > +++ b/gdb/gdbserver/linux-low.h > @@ -26,6 +26,7 @@ > /* Included for ptrace type definitions. */ > #include "nat/linux-ptrace.h" > #include "target/waitstatus.h" /* For enum target_stop_reason. */ > +#include "tracepoint.h" >=20=20 > #define PTRACE_XFER_TYPE long >=20=20 > @@ -358,7 +359,7 @@ struct lwp_info > return to the jump pad. Normally, we won't care about this, but > we will if a signal arrives to this lwp while it is > collecting. */ > - int collecting_fast_tracepoint; > + fast_tpoint_collect_result collecting_fast_tracepoint; The comments should be updated too. >=20=20 > /* If this is non-zero, it points to a chain of signals which need > to be reported to GDB. These were deferred because the thread Otherwise, the patch is good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)