Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: sunilkumar.dora@windriver.com
Cc: gdb-patches@sourceware.org, Randy.MacLeod@windriver.com,
	Sundeep.Kokkonda@windriver.com, kevinb@redhat.com,
	macro@orcam.me.uk, schwab@linux-m68k.org, tromey@sourceware.org,
	simark@simark.ca
Subject: Re: [PATCH v2] PR gdb/33747: gdb/ser-unix: Avoid musl build failure when setting custom baud rates
Date: Mon, 23 Feb 2026 05:24:43 +0200	[thread overview]
Message-ID: <867bs4cfb8.fsf@gnu.org> (raw)
In-Reply-To: <20260222200648.2648865-1-sunilkumar.dora@windriver.com>

> From: sunilkumar.dora@windriver.com
> Cc: sunilkumar.dora@windriver.com, Randy.MacLeod@windriver.com,
>  Sundeep.Kokkonda@windriver.com, kevinb@redhat.com, macro@orcam.me.uk,
>  schwab@linux-m68k.org, tromey@sourceware.org, simark@simark.ca
> Date: Sun, 22 Feb 2026 12:06:48 -0800
> 
> From: Sunil Dora <sunilkumar.dora@windriver.com>
> 
> The Linux custom baud rate implementation accessed the struct termios 
> members c_ispeed and c_ospeed directly. These fields are provided by 
> glibc but are not exposed by musl, which causes the build to fail on 
> musl-based systems.
> 
> Adjust set_custom_baudrate_linux to use a capability-based approach.
> The Autoconf check HAVE_NUMERIC_BAUD_RATES determines whether
> B-constants match numeric baud rates. If they do, use the standard
> POSIX cfsetispeed and cfsetospeed interfaces. Otherwise, fall back
> to the Linux-specific termios2 interface (TCGETS2) to support
> arbitrary baud rates.
> 
> This preserves existing behavior on glibc systems while restoring
> build compatibility with musl.
> 
> Signed-off-by: Sunil Dora <sunilkumar.dora@windriver.com>
> ---
>  gdb/NEWS         |  4 ++++
>  gdb/config.in    |  3 +++
>  gdb/configure    | 39 +++++++++++++++++++++++++++++++++++++++
>  gdb/configure.ac | 19 +++++++++++++++++++
>  gdb/ser-unix.c   | 42 ++++++++++++++++++++++++++----------------
>  5 files changed, 91 insertions(+), 16 deletions(-)

Thanks, the NEWS part is approved.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>

  reply	other threads:[~2026-02-23  3:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-22 20:06 sunilkumar.dora
2026-02-23  3:24 ` Eli Zaretskii [this message]
2026-03-09  1:25 ` Kevin Buettner
2026-03-10 13:38   ` Sunil Kumar Dora
2026-03-10 17:39     ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=867bs4cfb8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=Randy.MacLeod@windriver.com \
    --cc=Sundeep.Kokkonda@windriver.com \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    --cc=macro@orcam.me.uk \
    --cc=schwab@linux-m68k.org \
    --cc=simark@simark.ca \
    --cc=sunilkumar.dora@windriver.com \
    --cc=tromey@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox