From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GZUdK6HIm2lxZgYAWB0awg (envelope-from ) for ; Sun, 22 Feb 2026 22:25:21 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=nxDNST9J; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A95601E0BA; Sun, 22 Feb 2026 22:25:21 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A907C1E08D for ; Sun, 22 Feb 2026 22:25:20 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 297824BA23DB for ; Mon, 23 Feb 2026 03:25:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 297824BA23DB Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=nxDNST9J Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 937D64BA2E17; Mon, 23 Feb 2026 03:24:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 937D64BA2E17 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 937D64BA2E17 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771817095; cv=none; b=ei9hqJ1UUn+PT1sFphhcy88vdfsIbhxDXLdUG5KBCn7ht0R9+Yz70P9mX6LYfHFAfHM04lmQjVy+8wpTgZC7d4zCtyLRo29ECX2R+rmKDuP8sCOwZVXoWjyL911B/ZPvnu2kNw/baIK1uBqUadwy9EzpD1scZYWM94pXPr2/dBQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771817095; c=relaxed/simple; bh=Kp6teRZo7CjLi0IETVS0UDKspVZvJSrQUYySPWSzZRw=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=KqshcQOz62v+tQ+Hp9A4C5lRRZTTGUxBw4L4qUuNXY5FfIRfLngIHEkHwAV+vF1NFKkCo9ygYkoiAbxl0eoS06xkduyzTQ90GGjufNguwAIA12SKj5yFHIEuMqNkSVOznj0RIQNgFdikNxX4+/P9OP1N5R6rqKUT1z6ecLVhTiM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 937D64BA2E17 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vuMYw-0004ga-S6; Sun, 22 Feb 2026 22:24:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=WPjp7557VvZuOk9y/ETUD//thd7bYbqkBOI9T4jFJHc=; b=nxDNST9J7lf+ U74ediG2n4U/JZjNWaMk6f43FgIc1PcRTHLueA2nMV2wSgQjtK8mrQ2yWshrsskq2RoOoJCIcFcBy oQLCX5SZdls+y8kO05x1iDi7vhBMtTCSB3028r9Y7C8x2Ls7SggDrlztTkFXcOaNfLTYn4kMXx4q1 kiNqvkScWl3thfmuuUTdJa2v0A3tcDO56t9cOloxTtWig+xvcUhxMk4sbJo9oiq3i8Ot15G2aoflj X/zF5vA4v8iEWfENDhEJ2wD7d37j+ca8nF4oKYR9y6yqwdRjQCIqP725vqw/phhGrA5x9lX78tWxm e/UZbAleQCINOdzFIqlSig==; Date: Mon, 23 Feb 2026 05:24:43 +0200 Message-Id: <867bs4cfb8.fsf@gnu.org> From: Eli Zaretskii To: sunilkumar.dora@windriver.com Cc: gdb-patches@sourceware.org, Randy.MacLeod@windriver.com, Sundeep.Kokkonda@windriver.com, kevinb@redhat.com, macro@orcam.me.uk, schwab@linux-m68k.org, tromey@sourceware.org, simark@simark.ca In-Reply-To: <20260222200648.2648865-1-sunilkumar.dora@windriver.com> Subject: Re: [PATCH v2] PR gdb/33747: gdb/ser-unix: Avoid musl build failure when setting custom baud rates References: <20260222200648.2648865-1-sunilkumar.dora@windriver.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: sunilkumar.dora@windriver.com > Cc: sunilkumar.dora@windriver.com, Randy.MacLeod@windriver.com, > Sundeep.Kokkonda@windriver.com, kevinb@redhat.com, macro@orcam.me.uk, > schwab@linux-m68k.org, tromey@sourceware.org, simark@simark.ca > Date: Sun, 22 Feb 2026 12:06:48 -0800 > > From: Sunil Dora > > The Linux custom baud rate implementation accessed the struct termios > members c_ispeed and c_ospeed directly. These fields are provided by > glibc but are not exposed by musl, which causes the build to fail on > musl-based systems. > > Adjust set_custom_baudrate_linux to use a capability-based approach. > The Autoconf check HAVE_NUMERIC_BAUD_RATES determines whether > B-constants match numeric baud rates. If they do, use the standard > POSIX cfsetispeed and cfsetospeed interfaces. Otherwise, fall back > to the Linux-specific termios2 interface (TCGETS2) to support > arbitrary baud rates. > > This preserves existing behavior on glibc systems while restoring > build compatibility with musl. > > Signed-off-by: Sunil Dora > --- > gdb/NEWS | 4 ++++ > gdb/config.in | 3 +++ > gdb/configure | 39 +++++++++++++++++++++++++++++++++++++++ > gdb/configure.ac | 19 +++++++++++++++++++ > gdb/ser-unix.c | 42 ++++++++++++++++++++++++++---------------- > 5 files changed, 91 insertions(+), 16 deletions(-) Thanks, the NEWS part is approved. Reviewed-By: Eli Zaretskii