From: Yao Qi <qiyaoltc@gmail.com>
To: Pierre Langlois <pierre.langlois@arm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [AArch64] Rename boolean arguments in decoding functions
Date: Thu, 30 Jul 2015 11:24:00 -0000 [thread overview]
Message-ID: <864mklga6z.fsf@gmail.com> (raw)
In-Reply-To: <1438162390-30381-1-git-send-email-pierre.langlois@arm.com> (Pierre Langlois's message of "Wed, 29 Jul 2015 10:33:10 +0100")
Pierre Langlois <pierre.langlois@arm.com> writes:
> * aarch64-tdep.c (decode_b): Rename link argument to is_bl.
> Change its type to int *.
> (decode_br): Rename link argument to is_blr. Change its type to
> int *.
> (decode_cb): Rename op argument to is_cbnz. Change its type to
> int *.
> (decode_tb): Rename op argument to is_tbnz. Change its type to
> int *. Set is_tbnz to either 1 or 0.
> (aarch64_analyze_prologue): Change type of is_link to int. Add
> new variables is_cbnz and is_tbnz. Adjust call to
> aarch64_decode_cb and aarch64_decode_tb.
Patch looks good to me.
--
Yao (齐尧)
next prev parent reply other threads:[~2015-07-30 11:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 9:33 Pierre Langlois
2015-07-29 9:42 ` pinskia
2015-07-29 10:44 ` Pierre Langlois
2015-07-30 11:24 ` Yao Qi [this message]
2015-07-30 11:41 ` Pierre Langlois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864mklga6z.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.langlois@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox