From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26875 invoked by alias); 30 Jul 2015 11:24:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26861 invoked by uid 89); 30 Jul 2015 11:24:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f181.google.com Received: from mail-pd0-f181.google.com (HELO mail-pd0-f181.google.com) (209.85.192.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 30 Jul 2015 11:24:31 +0000 Received: by pdjr16 with SMTP id r16so23582788pdj.3 for ; Thu, 30 Jul 2015 04:24:30 -0700 (PDT) X-Received: by 10.70.134.133 with SMTP id pk5mr105289945pdb.133.1438255470234; Thu, 30 Jul 2015 04:24:30 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id cr4sm1720722pac.10.2015.07.30.04.24.28 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 30 Jul 2015 04:24:29 -0700 (PDT) From: Yao Qi To: Pierre Langlois Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [AArch64] Rename boolean arguments in decoding functions References: <1438162390-30381-1-git-send-email-pierre.langlois@arm.com> Date: Thu, 30 Jul 2015 11:24:00 -0000 In-Reply-To: <1438162390-30381-1-git-send-email-pierre.langlois@arm.com> (Pierre Langlois's message of "Wed, 29 Jul 2015 10:33:10 +0100") Message-ID: <864mklga6z.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00895.txt.bz2 Pierre Langlois writes: > * aarch64-tdep.c (decode_b): Rename link argument to is_bl. > Change its type to int *. > (decode_br): Rename link argument to is_blr. Change its type to > int *. > (decode_cb): Rename op argument to is_cbnz. Change its type to > int *. > (decode_tb): Rename op argument to is_tbnz. Change its type to > int *. Set is_tbnz to either 1 or 0. > (aarch64_analyze_prologue): Change type of is_link to int. Add > new variables is_cbnz and is_tbnz. Adjust call to > aarch64_decode_cb and aarch64_decode_tb. Patch looks good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)