Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: Andreas Arnez <arnez@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org,  Yao Qi <qiyaoltc@gmail.com>
Subject: Re: [PATCH] gnu_vector.exp: Respect `should_kfail' for PR8549
Date: Tue, 19 Jan 2016 17:33:00 -0000	[thread overview]
Message-ID: <864me9tqxc.fsf@gmail.com> (raw)
In-Reply-To: <m3h9i9sf64.fsf@oc1027705133.ibm.com> (Andreas Arnez's message of	"Tue, 19 Jan 2016 17:32:51 +0100")

Andreas Arnez <arnez@linux.vnet.ibm.com> writes:

> -gdb_test "p res" "\\{4, 2, 7, 6\\}.*" "verify vector return value"
> +set test "verify vector return value"
> +gdb_test_multiple "p res" $test {
> +    -re ".*= \\{4, 2, 7, 6\\}\r\n.*$gdb_prompt $" {
> +	pass $test
> +    }
> +    -re ".*= \\{10, 20, 48, 72\\}\r\n.*$gdb_prompt $" {
> +	if { $should_kfail } {
> +	    kfail "gdb/8549" $test
> +	} else {
> +	    fail $test
> +	}
> +    }
> +}

IMO, if GDB for a certain target doesn't handle "return" and "finish"
correctly, the return value can be some random results.  Why do we match
"\\{10, 20, 48, 72\\}" here?  I presume that because "10, 20, 48, 72"
was returned in the previous test.  Do *all* targets don't correctly handle
"return" and "finish" return "\\{10, 20, 48, 72\\}"?  In other words, if
we know it is broken already, why do still match the output?  We can
kfail it according to the target triplet.

-- 
Yao (齐尧)


  reply	other threads:[~2016-01-19 17:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-19 16:33 Andreas Arnez
2016-01-19 17:33 ` Yao Qi [this message]
2016-01-19 18:46   ` Andreas Arnez
2016-01-20  9:32     ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=864me9tqxc.fsf@gmail.com \
    --to=qiyaoltc@gmail.com \
    --cc=arnez@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox