From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60294 invoked by alias); 19 Jan 2016 17:33:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60261 invoked by uid 89); 19 Jan 2016 17:33:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=*all*, arnez, Arnez, triplet X-HELO: mail-pf0-f177.google.com Received: from mail-pf0-f177.google.com (HELO mail-pf0-f177.google.com) (209.85.192.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 19 Jan 2016 17:33:41 +0000 Received: by mail-pf0-f177.google.com with SMTP id e65so179221996pfe.0 for ; Tue, 19 Jan 2016 09:33:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type :content-transfer-encoding; bh=SOo6Zqo0aRB1DkDGDS9LyAK0iyfcJ70IP51NEF/X3tk=; b=X+MMIVFzLKM0BhWpOW6Y0zUKdsiCYWNXE4les+3DKQVYnOjobk5M6uhkAHJZwderO2 ZbT05YAQCMbtTagPPBSMcASH71HUs8p+JUaJAaHcPhTWAxgL4T+pWAPlAEEuoIDlVXG5 bhj+dgqC4hLMDBTB4b1nauGW8gnM/KGS+P5EHpMWfQlDdWXRXRZ69P2kZCo2kYizmtCp 9k0KmXyMpHSTOAiCbo3F9g0mWpCQ6oD9G7D5CGe3XS56IF909oYQIMvW5IvU7zBDYXUG fe7TFi0XB2LK5J6PBo3kvqtjhCeWnqFdb0iJwIdjO2LqWwLBuFbU7dPir+j8/RankuQx n2xg== X-Gm-Message-State: ALoCoQnYMX2jKaNOYYhPkgr7ZhX/jpUalQ435yV7B0D2F3NK0E+ZcvZ5fjrcPVv1s0YDzJJV/jH2b30roYig3BbkVyAph3GtMQ== X-Received: by 10.98.32.156 with SMTP id m28mr46239595pfj.74.1453224819751; Tue, 19 Jan 2016 09:33:39 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id ah10sm43231785pad.23.2016.01.19.09.33.37 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 19 Jan 2016 09:33:39 -0800 (PST) From: Yao Qi To: Andreas Arnez Cc: gdb-patches@sourceware.org, Yao Qi Subject: Re: [PATCH] gnu_vector.exp: Respect `should_kfail' for PR8549 References: Date: Tue, 19 Jan 2016 17:33:00 -0000 In-Reply-To: (Andreas Arnez's message of "Tue, 19 Jan 2016 17:32:51 +0100") Message-ID: <864me9tqxc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00442.txt.bz2 Andreas Arnez writes: > -gdb_test "p res" "\\{4, 2, 7, 6\\}.*" "verify vector return value" > +set test "verify vector return value" > +gdb_test_multiple "p res" $test { > + -re ".*=3D \\{4, 2, 7, 6\\}\r\n.*$gdb_prompt $" { > + pass $test > + } > + -re ".*=3D \\{10, 20, 48, 72\\}\r\n.*$gdb_prompt $" { > + if { $should_kfail } { > + kfail "gdb/8549" $test > + } else { > + fail $test > + } > + } > +} IMO, if GDB for a certain target doesn't handle "return" and "finish" correctly, the return value can be some random results. Why do we match "\\{10, 20, 48, 72\\}" here? I presume that because "10, 20, 48, 72" was returned in the previous test. Do *all* targets don't correctly handle "return" and "finish" return "\\{10, 20, 48, 72\\}"? In other words, if we know it is broken already, why do still match the output? We can kfail it according to the target triplet. --=20 Yao (=E9=BD=90=E5=B0=A7)