From: Yao Qi <qiyaoltc@gmail.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: <gdb-patches@sourceware.org>, <qiyaoltc@gmail.com>,
<palves@redhat.com>, <antoine.tremblay@ericsson.com>
Subject: Re: [PATCH 1/2] Change gdb_load_shlibs to gdb_load_shlib
Date: Thu, 14 Apr 2016 09:33:00 -0000 [thread overview]
Message-ID: <864mb4o7qq.fsf@gmail.com> (raw)
In-Reply-To: <1460502865-10999-1-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Tue, 12 Apr 2016 19:14:24 -0400")
Simon Marchi <simon.marchi@ericsson.com> writes:
> -proc gdb_load_shlibs { args } {
> - foreach file $args {
> - gdb_remote_download target [shlib_target_file $file]
> - }
> +proc gdb_load_shlib { file } {
> + set dest [gdb_remote_download target [shlib_target_file $file]]
Why don't define a new proc gdb_load_shlib but leave gdb_load_shlibs
there? gdb_load_shlibs can invoke gdb_load_shlib in a loop, and callers
of gdb_load_shlibs are not changed.
--
Yao (齐尧)
next prev parent reply other threads:[~2016-04-14 9:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 23:14 Simon Marchi
2016-04-12 23:14 ` [PATCH 2/2] ftrace tests: Use gdb_load_shlib result to lookup IPA in info sharedlibrary Simon Marchi
2016-04-13 18:18 ` [PATCH 1/2] Change gdb_load_shlibs to gdb_load_shlib Pedro Alves
2016-04-13 21:05 ` Simon Marchi
2016-04-14 11:28 ` Pedro Alves
2016-04-14 9:33 ` Yao Qi [this message]
2016-04-14 15:17 ` Simon Marchi
2016-04-14 15:27 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864mb4o7qq.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox