From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36572 invoked by alias); 14 Apr 2016 09:33:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36561 invoked by uid 89); 14 Apr 2016 09:33:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pf0-f175.google.com Received: from mail-pf0-f175.google.com (HELO mail-pf0-f175.google.com) (209.85.192.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 14 Apr 2016 09:33:19 +0000 Received: by mail-pf0-f175.google.com with SMTP id e128so44397471pfe.3 for ; Thu, 14 Apr 2016 02:33:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=HYT0o9EF8c/JX0VenOYOdnZXMh+wFEqIDbthMaDcg14=; b=PfNFrJ+Y/t+QBUznUwSgRTvilbv4i3Dd4wxrJ0UwXj68sFtGaRpm6E3LLkWeqk1i4V PjPSltRyGVou3rvVTdtiMSTLVtIgE05dxpq+Iq8/jdJ8288gRF6xebGdoKP3Xgc66HHl PlpeKtqqzp+2G/Za3oH1hQeJMeXo1a6h8uR5icHNvDg991QxxgVd0nu49qSf+Gqptm9W f/lOXtYXgBJg5du96d7Sc+V6+n23QxjP/sWmuCJmIdfpUaadyBFvD8Oy+SzuzDwgTP5U BsZ8wvT7TpTndWuKxzQhyovlRJBRE36u/BkuMp5ATAWkr/9nLkGPVI/MHGcAGqdbsnNj sWXQ== X-Gm-Message-State: AOPr4FWM4mMYMQCTjQHxQRAHtNM/5bcy/tM7O/n9yB5KfE/HRx/KCXziRVO3645iG1wZpg== X-Received: by 10.98.71.86 with SMTP id u83mr19630415pfa.156.1460626397324; Thu, 14 Apr 2016 02:33:17 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id fn3sm56644883pab.20.2016.04.14.02.33.14 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 14 Apr 2016 02:33:16 -0700 (PDT) From: Yao Qi To: Simon Marchi Cc: , , , Subject: Re: [PATCH 1/2] Change gdb_load_shlibs to gdb_load_shlib References: <1460502865-10999-1-git-send-email-simon.marchi@ericsson.com> Date: Thu, 14 Apr 2016 09:33:00 -0000 In-Reply-To: <1460502865-10999-1-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Tue, 12 Apr 2016 19:14:24 -0400") Message-ID: <864mb4o7qq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00317.txt.bz2 Simon Marchi writes: > -proc gdb_load_shlibs { args } { > - foreach file $args { > - gdb_remote_download target [shlib_target_file $file] > - } > +proc gdb_load_shlib { file } { > + set dest [gdb_remote_download target [shlib_target_file $file]] Why don't define a new proc gdb_load_shlib but leave gdb_load_shlibs there? gdb_load_shlibs can invoke gdb_load_shlib in a loop, and callers of gdb_load_shlibs are not changed. --=20 Yao (=E9=BD=90=E5=B0=A7)