From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Import strtok_r gnulib module
Date: Thu, 09 Apr 2015 09:10:00 -0000 [thread overview]
Message-ID: <863849wttw.fsf@gmail.com> (raw)
In-Reply-To: <1428513587-8471-3-git-send-email-palves@redhat.com> (Pedro Alves's message of "Wed, 8 Apr 2015 18:19:47 +0100")
Pedro Alves <palves@redhat.com> writes:
> gdb/linux-tdep.c recently gained a strtok_r use. That broke
> --enable-targets=all with some versions of mingw64, which don't have
> strtok_r:
>
> https://sourceware.org/ml/gdb-patches/2015-04/msg00266.html
>
> Fix that by importing the strtok_r gnulib module.
Patch is OK to me.
>
> gdb/ChangeLog:
> 2015-04-08 Pedro Alves <palves@redhat.com>
>
> * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add strtok_r.
> * gnulib/Makefile.in (aclocal_m4_deps): Add import/m4/strtok_r.m4.
Nit: gnulib/Makefile.in is regenerated, isn't? If so, "Regenerate"
should be used too.
> * gnulib/configure, gnulib/config.in, gnulib/aclocal.m4: Regenerate.
> * gnulib/import/Makefile.am: Update.
> * gnulib/import/Makefile.in: Update.
> * gnulib/import/m4/gnulib-cache.m4: Update.
> * gnulib/import/m4/gnulib-comp.m4: Update.
> * gnulib/import/m4/strtok_r.m4: New file.
> * gnulib/import/strtok_r.c: New file.
--
Yao (齐尧)
next prev parent reply other threads:[~2015-04-09 9:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 17:19 [PATCH 0/2] Import gnulib strtok_r module Pedro Alves
2015-04-08 17:19 ` [PATCH 1/2] update-gnulib.sh: work around aclocal warning with Perl >= 5.16 Pedro Alves
2015-04-09 9:03 ` Yao Qi
2015-04-09 9:39 ` Pedro Alves
2015-04-08 17:19 ` [PATCH 2/2] Import strtok_r gnulib module Pedro Alves
2015-04-09 9:10 ` Yao Qi [this message]
2015-04-09 9:30 ` Pedro Alves
2015-04-09 9:39 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=863849wttw.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox