From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45198 invoked by alias); 9 Apr 2015 09:10:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45185 invoked by uid 89); 9 Apr 2015 09:10:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f54.google.com Received: from mail-pa0-f54.google.com (HELO mail-pa0-f54.google.com) (209.85.220.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 09 Apr 2015 09:10:26 +0000 Received: by pabtp1 with SMTP id tp1so38063671pab.2 for ; Thu, 09 Apr 2015 02:10:24 -0700 (PDT) X-Received: by 10.70.0.98 with SMTP id 2mr54718031pdd.55.1428570624391; Thu, 09 Apr 2015 02:10:24 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by mx.google.com with ESMTPSA id cj2sm13588539pbb.10.2015.04.09.02.10.22 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 09 Apr 2015 02:10:23 -0700 (PDT) From: Yao Qi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Import strtok_r gnulib module References: <1428513587-8471-1-git-send-email-palves@redhat.com> <1428513587-8471-3-git-send-email-palves@redhat.com> Date: Thu, 09 Apr 2015 09:10:00 -0000 In-Reply-To: <1428513587-8471-3-git-send-email-palves@redhat.com> (Pedro Alves's message of "Wed, 8 Apr 2015 18:19:47 +0100") Message-ID: <863849wttw.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00318.txt.bz2 Pedro Alves writes: > gdb/linux-tdep.c recently gained a strtok_r use. That broke > --enable-targets=3Dall with some versions of mingw64, which don't have > strtok_r: > > https://sourceware.org/ml/gdb-patches/2015-04/msg00266.html > > Fix that by importing the strtok_r gnulib module. Patch is OK to me. > > gdb/ChangeLog: > 2015-04-08 Pedro Alves > > * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add strtok_r. > * gnulib/Makefile.in (aclocal_m4_deps): Add import/m4/strtok_r.m4. Nit: gnulib/Makefile.in is regenerated, isn't? If so, "Regenerate" should be used too. > * gnulib/configure, gnulib/config.in, gnulib/aclocal.m4: Regenerate. > * gnulib/import/Makefile.am: Update. > * gnulib/import/Makefile.in: Update. > * gnulib/import/m4/gnulib-cache.m4: Update. > * gnulib/import/m4/gnulib-comp.m4: Update. > * gnulib/import/m4/strtok_r.m4: New file. > * gnulib/import/strtok_r.c: New file. --=20 Yao (=E9=BD=90=E5=B0=A7)