From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2/htab 4/6] [Linux] Optimize PID -> struct lwp_info lookup
Date: Tue, 24 May 2016 09:33:00 -0000 [thread overview]
Message-ID: <861t4r6bs2.fsf@gmail.com> (raw)
In-Reply-To: <c331c6b6-f38e-ba10-1789-630732e14490@redhat.com> (Pedro Alves's message of "Mon, 23 May 2016 19:10:13 +0100")
Pedro Alves <palves@redhat.com> writes:
Hi Pedro,
Patch is good to me, a nit on comments,
> +/* Head of double-linked list of known LWPs. Sorted by reverse
> + creation order. This order is assumed in some cases. E.g.,
> + reaping status after killing alls lwps of a process: the leader LWP
> + must be reaped last. */
> struct lwp_info *lwp_list;
> +
> +/* Add LP to sorted-by-creation-order double-linked list. */
> +
To reflect the code,
s/sorted-by-creation-order/sorted-by-reverse-creation-order/
> +
> +/* Remove LP from sorted-by-creation-order double-linked list. */
> +
Likewise.
>
> - /* Next LWP in list. */
> + /* Previous and next pointers in double-linked list of known LWPs,
> + sorted by reverse creation order. */
> + struct lwp_info *prev;
--
Yao (齐尧)
next prev parent reply other threads:[~2016-05-24 9:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 14:48 [PATCH 0/6] Fix PR gdb/19828 (attach -> internal error) and attach optimizations Pedro Alves
2016-05-19 14:48 ` [PATCH 3/6] [Linux] Avoid refetching core-of-thread if thread hasn't run Pedro Alves
2016-05-23 12:45 ` Yao Qi
2016-05-19 14:48 ` [PATCH 2/6] [Linux] Read vDSO range from /proc/PID/task/PID/maps instead of /proc/PID/maps Pedro Alves
2016-05-23 11:08 ` Yao Qi
2016-05-19 14:48 ` [PATCH 1/6] Linux native thread create/exit events support Pedro Alves
2016-05-23 10:49 ` Yao Qi
2016-05-23 13:00 ` Pedro Alves
2016-05-19 14:56 ` [PATCH 5/6] Make gdb/linux-nat.c consider a waitstatus pending on the infrun side Pedro Alves
2016-05-19 14:57 ` [PATCH 6/6] Fix PR gdb/19828: gdb -p <process from a container>: internal error Pedro Alves
2016-05-23 10:14 ` Yao Qi
2016-05-25 17:43 ` [pushed/7.11.1] " Pedro Alves
2016-05-19 14:57 ` [PATCH 4/6] [Linux] Optimize PID -> struct lwp_info lookup Pedro Alves
2016-05-23 13:12 ` Yao Qi
2016-05-23 18:10 ` [PATCH v2/htab " Pedro Alves
2016-05-24 9:33 ` Yao Qi [this message]
2016-05-24 13:47 ` Pedro Alves
2016-05-19 15:11 ` [PATCH 0/6] Fix PR gdb/19828 (attach -> internal error) and attach optimizations Pedro Alves
2016-05-24 13:57 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=861t4r6bs2.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox