From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128491 invoked by alias); 24 May 2016 09:33:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128478 invoked by uid 89); 24 May 2016 09:33:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Head X-HELO: mail-pa0-f65.google.com Received: from mail-pa0-f65.google.com (HELO mail-pa0-f65.google.com) (209.85.220.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 24 May 2016 09:33:31 +0000 Received: by mail-pa0-f65.google.com with SMTP id fg1so1478781pad.3 for ; Tue, 24 May 2016 02:33:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=komSOkeFLyaLEx1yZgrOS6TR91KpTYp7F5gXhbrrDCw=; b=Ud2uiL8vHKWWam0xeStIm8YKslFySZelbemTkJ3vqna+/Ehq7nKXsBt3FiJhiEtqgb evzStQART9L5jD9oKNXdsY1UVCNfXzMACqwHnevu4vWCLK02jHMoJ+2VBCCeglNItHgH h+tjPD/WF0yM6ltW22/Ldt5lfKnLu44BpEWeGgs57EF1Ctk+3F6FR8G49Qe+Ei+2abue 6/ikP2ioi3R4xdyhtIj1lIEOo0b0EaNnAzrC4vM5T9rjNVe8ZFUT+oOqJiKuZFv1UBsL 9rOKdfjJnzFw/RYYbcdS0A08VcG4wFYG0/6iZnFlz7DjkQtI0bRtV5npZ4lf5iQg6Ife 9HQw== X-Gm-Message-State: ALyK8tKuz+ywbTxlf46pols5Bc2nPARXY7Ml2KTbK9sq5RUdjjx86eDtKHrBF1qiXt9UQQ== X-Received: by 10.66.123.105 with SMTP id lz9mr5260941pab.37.1464082409854; Tue, 24 May 2016 02:33:29 -0700 (PDT) Received: from E107787-LIN (gcc113.osuosl.org. [140.211.9.71]) by smtp.gmail.com with ESMTPSA id 141sm15597385pfx.68.2016.05.24.02.33.27 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 24 May 2016 02:33:28 -0700 (PDT) From: Yao Qi To: Pedro Alves Cc: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH v2/htab 4/6] [Linux] Optimize PID -> struct lwp_info lookup References: <1463669290-30415-1-git-send-email-palves@redhat.com> <1463669290-30415-5-git-send-email-palves@redhat.com> <86d1oc7wb4.fsf@gmail.com> Date: Tue, 24 May 2016 09:33:00 -0000 In-Reply-To: (Pedro Alves's message of "Mon, 23 May 2016 19:10:13 +0100") Message-ID: <861t4r6bs2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00414.txt.bz2 Pedro Alves writes: Hi Pedro, Patch is good to me, a nit on comments, > +/* Head of double-linked list of known LWPs. Sorted by reverse > + creation order. This order is assumed in some cases. E.g., > + reaping status after killing alls lwps of a process: the leader LWP > + must be reaped last. */ > struct lwp_info *lwp_list; > + > +/* Add LP to sorted-by-creation-order double-linked list. */ > + To reflect the code, s/sorted-by-creation-order/sorted-by-reverse-creation-order/ > + > +/* Remove LP from sorted-by-creation-order double-linked list. */ > + Likewise. >=20=20 > - /* Next LWP in list. */ > + /* Previous and next pointers in double-linked list of known LWPs, > + sorted by reverse creation order. */ > + struct lwp_info *prev; --=20 Yao (=E9=BD=90=E5=B0=A7)